Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Make engine hold AccountProvider #3725

Merged
merged 12 commits into from
Dec 8, 2016
Merged

Make engine hold AccountProvider #3725

merged 12 commits into from
Dec 8, 2016

Conversation

keorn
Copy link

@keorn keorn commented Dec 5, 2016

Adds a cli --engine-signer ADDRESS (to be used with --password) and parity_setEngineSigner(address, password) RPC.
Now Engine can sign messages whenever it wants without unlocking the account permanently or using --author.

@keorn keorn added A0-pleasereview 🤓 Pull request needs code review. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M4-core ⛓ Core client code / Rust. labels Dec 5, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 85.922% when pulling 92d566c on engine-password into ad36743 on master.

@gavofyork
Copy link
Contributor

would it make sense to choose one of setEngineSigner/setConsensusSigner and stick with it throughout?

@keorn
Copy link
Author

keorn commented Dec 5, 2016

Sure will change the internals, had to change since --consensus-signer was too long for the current cli setup.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 85.896% when pulling 0a2ec31 on engine-password into ad36743 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 85.896% when pulling b089aa7 on engine-password into ad36743 on master.

@keorn keorn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 7, 2016
@keorn keorn added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Dec 7, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 85.905% when pulling 71a9658 on engine-password into ad36743 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 85.864% when pulling 727ace0 on engine-password into ad36743 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 85.914% when pulling 727ace0 on engine-password into ad36743 on master.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 8, 2016
@gavofyork gavofyork merged commit 2d6656f into master Dec 8, 2016
@gavofyork gavofyork deleted the engine-password branch December 8, 2016 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants