Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Removing all old entries from transaction queue #3772

Merged
merged 4 commits into from
Dec 10, 2016
Merged

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Dec 9, 2016

  • Run some tests to see if the removal process works correctly without increased overhead.

Previously when node went to "syncing" status for some time some notifications about enacted blocks were not propagated to the queue, preventing stalled transactions from being removed.

@tomusdrw tomusdrw added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M4-core ⛓ Core client code / Rust. labels Dec 9, 2016
@tomusdrw tomusdrw requested a review from arkpar December 9, 2016 15:08
@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Dec 9, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c91a614 on txqueue-gc into ** on master**.

Conflicts:
	ethcore/src/miner/miner.rs
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 85.609% when pulling 1f9adc8 on txqueue-gc into a6fcd8a on master.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 10, 2016
@gavofyork gavofyork merged commit aa30619 into master Dec 10, 2016
@gavofyork gavofyork deleted the txqueue-gc branch December 10, 2016 22:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants