This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix Wallet Settings Modal #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Dec 15, 2016
| @@ -105,7 +104,7 @@ export default class WalletDetails extends Component { | |||
| value={ wallet.owners.slice() } | |||
| onChange={ this.onOwnersChange } | |||
| accounts={ accounts } | |||
| param={ parseAbiType('address[]') } | |||
| param='address[]' | |||
There was a problem hiding this comment.
Would have been good to just order here, however not a crisis.
jacogr
reviewed
Dec 15, 2016
| }; | ||
|
|
||
| static defaultProps = { | ||
| min: null, | ||
| max: null, | ||
| isEth: false | ||
| isEth: null |
There was a problem hiding this comment.
Null for bool? Going to run into issues again, need to stop doing tri-states.
There was a problem hiding this comment.
Alternatively just fix the PropTypes to be explicit on what it required, null or bool
There was a problem hiding this comment.
Ah yes missed that one. The idea is just that by default it's using the given param, but if isEth is passed, then it will show the ETH toggle. If isEth is true => default to ETH value, if not, default to integer value. Will change the PropTypes though
jacogr
added
A6-mustntgrumble 💦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the wrong
requirefield in Wallet Settings modal.Also, stop defaulting Uint TypedInput with the
ETHtoggle. Only for contracts now.