This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fix deadlock in queue drop #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
arkpar
reviewed
Dec 19, 2016
| { | ||
| let _more = self.verification.more_to_verify.lock().unwrap(); | ||
| } | ||
|
|
||
| // wake up all threads waiting for more work. | ||
| self.more_to_verify.notify_all(); |
There was a problem hiding this comment.
This call should be made under the lock as well.
There was a problem hiding this comment.
i think that would cause a deadlock in itself, since any notified thread needs to have the lock returned from the wait call.
There was a problem hiding this comment.
It should not. Condvar::wait makes sure that start of wait and release of the lock are synchronized.
arkpar
added
A4-gotissues 💥
rphmeier
force-pushed
the
test-mem-limit-deadlock
branch
from
a9f05cc to
2d91ef5
Compare
rphmeier
added
A0-pleasereview 🤓
rphmeier
force-pushed
the
test-mem-limit-deadlock
branch
from
2d91ef5 to
ae8f77b
Compare
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3885