This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fetch tests (first batch) #3977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 27, 2016 12:27
tomusdrw
added
A0-pleasereview 🤓
Conflicts: dapps/src/lib.rs
rphmeier
reviewed
Dec 27, 2016
| /// Set a fetch client to use. | ||
| pub fn with_fetch(&mut self, fetch: FetchClient) { | ||
| self.fetch = Some(fetch); | ||
| pub fn fetch<X: Fetch>(self, fetch: X) -> ServerBuilder<X> { |
There was a problem hiding this comment.
why not pub fn fetch(self, fetch: T) -> Self?
There was a problem hiding this comment.
It would need type hints when calling ServerBuilder::new() in such case and builder would be tied to a single implementation of Fetch.
Currently you can just do ServerBuilder::new() to have a default implementation and then call fetch(fetch_instance) to change the type. We use different fetch only for tests.
|
Changes Unknown when pulling 2ed212b on fetch-tests into ** on master**. |
gavofyork
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for content fetch, dapp fetch and web-based streaming.