This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Zero-alloc trie lookups #3998
Merged
Zero-alloc trie lookups #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
|
Changes Unknown when pulling dcf7881 on trie-iterative into ** on master**. |
rphmeier
commented
Dec 30, 2016
| } | ||
|
|
||
| impl<'a> Query for &'a mut Recorder { | ||
| type Item = DBValue; |
There was a problem hiding this comment.
Since recording queries often don't care about the value itself it might make sense just to use () here.
|
an additional test or two for the new API? |
|
@gavofyork Not 100% sure what there is left to test -- Regular |
|
Changes Unknown when pulling 3f3d1a5 on trie-iterative into ** on master**. |
gavofyork
added
A8-looksgood 🦄
|
didn't see any unit tests specifically targeting |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trie half of #3993
Also does some more code cleanup and adds an
OwnedNodetype which can be used for trie iterators.The shared portion of lookup with TrieDB and TrieDBMut is refactored into a
lookupmodule which was simpler to write iteratively. When HashDB getsget_withthen it will use that and be truly zero-alloc.