Use TypedInputs in Contracts view #4015
Conversation
| @@ -78,7 +78,7 @@ class InputAddress extends Component { | |||
| return ( | |||
| <div className={ containerClasses.join(' ') }> | |||
| <Input | |||
| allowCopy={ allowCopy && (disabled ? value : false) } | |||
| allowCopy={ allowCopy && ((disabled || readOnly) ? value : false) } | |||
There was a problem hiding this comment.
allowCopy && !disabled && !readOnly && value?
There was a problem hiding this comment.
We want it to be false if value is falsy, because otherwise (if allowCopy isn't a boolean) the copy button would show and copy the passed value (could be '')
| this.setState({ isEth: true, ethValue: fromWei(this.props.value) }); | ||
| const { isEth, value } = this.props; | ||
|
|
||
| if (typeof isEth === 'boolean' && value) { |
There was a problem hiding this comment.
I guess there is a specific reason for this, but isn't boolean validation done by propTypes already?
There was a problem hiding this comment.
It could be undefined I think
There was a problem hiding this comment.
So the logic is :
- If
isEthis a prop (falseortrue), then theETHtoggle will be shown forintegerinputs
The prop value will then be the default toggle state (ie.falsedoesn't convert the value toETHby default) - Else (ie.
undefined, not aboolean), don't show the toggle at all
There was a problem hiding this comment.
Ok, then my only grumble is the tri-state isEth (null is the default value).
There was a problem hiding this comment.
Well it's more or less like allowCopy : could be true or false whether to show it or not, or the value to actually copy. I agree that it might not be the best, but I'm not sure that it's in the scope of this PR.
| label={ label } | ||
| hint={ hint } | ||
| value={ realValue } | ||
| error={ error } | ||
| onChange={ onChange } | ||
| type='number' | ||
| readOnly={ readOnly } | ||
| type={ readOnly ? 'text' : 'number' } |
There was a problem hiding this comment.
Because if the TypedInput is read only and a number, we display the formatted number (which must be in a text input then)
| const param = this.getParam(); | ||
|
|
||
| const realValue = value && typeof value.toNumber === 'function' | ||
| ? value.toNumber() | ||
| ? (readOnly ? value.toFormat() : value.toNumber()) |
There was a problem hiding this comment.
[tiny grumble] I'd rather check if it's a BigNumber here, because you use both toFormat & toNumber.
| label={ label } | ||
| hint={ hint } | ||
| value={ value } | ||
| editing |
There was a problem hiding this comment.
afaict editing does not exist as a prop.
| } else if (api.util.isArray(value)) { | ||
| } | ||
|
|
||
| if (api.util.isArray(value)) { |
There was a problem hiding this comment.
Something is returned in the previous if statement, thus no need for else
jacogr
added
A8-looksgood 🦄
Closes #3918