This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
[beta] Avoid re-broadcasting transactions on each block #4047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
tomusdrw
added
A3-inprogress ⏳
tomusdrw
added
A0-pleasereview 🤓
|
we probably want to rebroadcast from time to time, though; transactions not getting through at all is a showstopper. |
|
Maybe we can randomly choose few (0-2) peers that we'll rebroadcast the transactions to on each block? |
|
separate PR for the backport of random subset or not? |
|
I think it will be easier to backport #4054 separately. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently 1.4.x is re-broadcasting all transactions after each block is imported.
That's not nice to other peers and may cause excessive traffic.
Related: #4007, #3996, #3358