This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A1-onice 🌨
Pull request is reviewed well, but should not yet be merged.
M4-core ⛓
Core client code / Rust.
A0-pleasereview 🤓
Pull request needs code review.
and removed
A1-onice 🌨
Pull request is reviewed well, but should not yet be merged.
labels
Jan 10, 2017
arkpar
added
A8-looksgood 🦄
Pull request is reviewed well.
A7-looksgoodtestsfail 🤖
Pull request is reviewed well, but cannot be merged due to tests failing.
and removed
A0-pleasereview 🤓
Pull request needs code review.
A8-looksgood 🦄
Pull request is reviewed well.
labels
Jan 10, 2017
rphmeier
force-pushed
the
lightsync-tests
branch
from
January 10, 2017 17:51
542e95c
to
8e5281d
Compare
rphmeier
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A7-looksgoodtestsfail 🤖
Pull request is reviewed well, but cannot be merged due to tests failing.
labels
Jan 10, 2017
Changes Unknown when pulling 8e5281d on lightsync-tests into ** on master**. |
I'm confused about the sync test failure here -- nothing changed here affects the edit: should be fixed now |
failed twice. |
gavofyork
added
A7-looksgoodtestsfail 🤖
Pull request is reviewed well, but cannot be merged due to tests failing.
and removed
A8-looksgood 🦄
Pull request is reviewed well.
labels
Jan 11, 2017
arkpar
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A7-looksgoodtestsfail 🤖
Pull request is reviewed well, but cannot be merged due to tests failing.
labels
Jan 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #3974
Also fixes a couple small bugs, adds debug formatting. No tests yet since there are currently issues with how it handles the head of the chain -- sync, fork tests, etc. will come with PeerSearch + chain head downloader.