This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
verification: don't request a code twice #4221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Jan 19, 2017
| export const hasReceivedCode = (email, address, isTestnet = false) => { | ||
| const port = isTestnet ? 28443 : 18443; | ||
| const query = stringify({ email, address }); | ||
| return fetch(`https://email-verification.parity.io:${port}/?` + query, { |
There was a problem hiding this comment.
- Blank line before
- Why are we using template strings & ES6-style string +'s in one?
jacogr
reviewed
Jan 19, 2017
| export const hasReceivedCode = (number, address, isTestnet = false) => { | ||
| const port = isTestnet ? 8443 : 443; | ||
| const query = stringify({ number, address }); | ||
| return fetch(`https://sms-verification.parity.io:${port}/?` + query, { |
There was a problem hiding this comment.
Copied from above, will change. Although I disagree 😁
jacogr
reviewed
Jan 19, 2017
| @@ -21,7 +21,7 @@ import SMSVerificationABI from '~/contracts/abi/sms-verification.json'; | |||
| import VerificationStore, { | |||
| LOADING, QUERY_DATA, QUERY_CODE, POSTED_CONFIRMATION, DONE | |||
| } from './store'; | |||
| import { isServerRunning, postToServer } from '../../3rdparty/sms-verification'; | |||
| import { isServerRunning, hasReceivedCode, postToServer } from '../../3rdparty/sms-verification'; | |||
There was a problem hiding this comment.
Since we are touching the line, always prefer ~/3rdparty to ../../3rdparty
There was a problem hiding this comment.
You're right. Just adapted it without paying attention.
jacogr
reviewed
Jan 19, 2017
| const port = isTestnet ? 28443 : 18443; | ||
| const query = stringify({ email, address }); | ||
| return fetch(`https://email-verification.parity.io:${port}/?` + query, { | ||
| mode: 'cors', cache: 'no-store' |
There was a problem hiding this comment.
Prefer multi-key objects to have a single entry per line.
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better UX for the verification process. Users haven't been able to close the verification modal/page as soon as they had requested a code.