Web view with web3.site support #4313
Conversation
jacogr
added
A3-inprogress ⏳
jacogr
added
A1-onice 🌨
|
is ethlink a PR? |
|
@gavofyork Not yet. First need https://github.com/ethcore/parity/pull/4302 in, then @tomusdrw will probably PR that one (Myself and him have been testing the branch extensively, actually my current running Parity version, but it still needs a tweak or two) |
tomusdrw
added
M4-core ⛓
| onChange={ this.onChangeUrl } | ||
| onGoto={ this.onGotoUrl } | ||
| onRestore={ this.onRestoreUrl } | ||
| url={ nextUrl } | ||
| /> | ||
| <Button | ||
| disabled={ isPristine } |
There was a problem hiding this comment.
Not sure if that's the wanted behavior, but the Button is disabled if the URL isPristine, but pressing <enter> still calls onGotoUrl
There was a problem hiding this comment.
It's the same as in standard browser, no?
There was a problem hiding this comment.
I don't have any Go button on Chrome, so not sure. I think it's more used as: if the URL is pristine, then have the reload button ; if not, have the go button
There was a problem hiding this comment.
(Any way I just wanted to point out this behavior, which is totally fine with me, just in case it wasn't expected)
|
JS LGTM. |
gavofyork
added
A8-looksgood 🦄
web3.siteand new web-encoding.