Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Display ETH balance in overlay account selector #4588

Merged
merged 9 commits into from
Feb 22, 2017
Merged

Display ETH balance in overlay account selector #4588

merged 9 commits into from
Feb 22, 2017

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Feb 17, 2017 •
edited
Loading

parity 2017-02-17 16-18-58

parity 2017-02-17 16-31-37

parity 2017-02-21 10-56-09

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 17, 2017
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Feb 17, 2017
@gavofyork gavofyork requested a review from ngotchac February 20, 2017 17:32
ngotchac
ngotchac reviewed Feb 21, 2017
View reviewed changes
Copy link
Contributor

@ngotchac ngotchac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the vaults are in, we might want to add the balance to the AccountCard in src/modals/VaultAccounts/vaultAccounts.js ?

@ngotchac ngotchac added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 21, 2017
@jacogr
Copy link
Contributor Author

jacogr commented Feb 21, 2017

Good catch, happens when we have multiple branches going. Will add for consistency.

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Feb 21, 2017
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Feb 21, 2017
@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 21, 2017
@gavofyork gavofyork merged commit 0a85fc7 into master Feb 22, 2017
@gavofyork gavofyork deleted the jg-paritybar-balance branch February 22, 2017 09:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ngotchac ngotchac ngotchac left review comments

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacogr @ngotchac @gavofyork