This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
[beta] Fix Geth account import #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A0-pleasereview 🤓
derhuerst
reviewed
Feb 22, 2017
| .then((result) => { | ||
| console.log('result', result); | ||
| .then((gethImported) => { | ||
| console.log('result', gethImported); |
There was a problem hiding this comment.
most likely an unwanted console.log.
There was a problem hiding this comment.
No, was there on purpose, left in.
There was a problem hiding this comment.
Please use a more fitting description than "result" then.
derhuerst
reviewed
Feb 22, 2017
| @@ -106,7 +106,7 @@ export default class NewGeth extends Component { | |||
| api.parity | |||
| .listGethAccounts() | |||
| .then((_addresses) => { | |||
| const addresses = (addresses || []).filter((address) => !accounts[address]); | |||
There was a problem hiding this comment.
Interesting, this should have been catched by the linter with _addresses being an unused variable.
There was a problem hiding this comment.
Yeap. The worst was I tracked this one down in the PRs and it was fixed in master when moved to MobX store - but only after manual testing. I remember this one when I saw it, even there it was also not caught.
derhuerst
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parity_importGethAccounts(backport of RPC commit in https://github.com/ethcore/parity/pull/4641)