Misc. small UI fixes #4657

jacogr · 2017-02-23T19:25:12Z

Shorten menubar entries to relevant words (Closes Accounts Bar could be more helpful on smal screens #4644)
- Accounts, Addresses, Contracts
- Account, Address, Contract
Fields
- Input - add onDefaultAction callback prop
- AddressInput - add autoFocus prop
Delete Account
- Auto focus password field
- Create on enter in field
Open Vault
- Auto focus on password field
- Fix default action (not on tab, Enter only)
- Add Form around inputs with extra padding
Create Account
- Normal account - Auto-focus name field
- JSON imports - Auto-focus name field
- Raw key - Auto-focus key field
- Recovery phrase - Auto-focus field & clear phrase between use
Create Wallet
- MultiSig - put entry fields first, auto-focus name
- Watch - Auto-focus name
Add Address
- Auto-focus on address field
Add Contract
- Auto-focus address field (all ABI types)
Deploy contract
- Auto-focus name field
- Re-arrange fields to have focussable field first
Edit Meta
- Auto-focus name field
Wallet Settings
- Auto-focus modifications field
Verification
- Auto-focus first data field
- Auto-focus verification number field

ngotchac

Small comments, and some buttons where label has been changed could use FormattedMessages.

This also brings the question of translation files. Shouldn't they be updated with this PR, as some values changed? What about the other languages that have already translated these?

ngotchac · 2017-02-24T10:26:33Z

js/src/modals/AddAddress/addAddress.js

@@ -89,7 +89,7 @@ export default class AddAddress extends Component {
        onClick={ this.onAdd }
        ref='addButton'
      />
-    ]);
+    ];


The Buttons miss the key prop. And while we're at it, we might want to get rid of every Cancel button for modals that use the Portal. There is already this big X button to cancel/close the modal/Portal.

Not trying to fix the all button layouts here. Wait for modal updates round 2, 3, etc. (Need to work through one-by-one to see what works and what doesn't - help is appreciated there, it is a lot of ground to cover to say the least.)

Key is valuable though.

Ummm... I actually fixed this in my modals update branch (along with a ton of others, we didn't seem to be as vigilant as we should have), however re-doing it here.

ngotchac · 2017-02-24T10:28:53Z

js/src/views/Address/address.js

@@ -153,7 +153,7 @@ class Address extends Component {
      <Button
        key='delete'
        icon={ <ActionDelete /> }
-        label='forget address'
+        label='forget'


FormattedMessage ?

I have an i18n branch going, starting my way up from the bottom of the views, will get to that in there. Not doing in here, minor tweaks before release, nothing more.

jacogr · 2017-02-24T11:16:03Z

Comments addressed, merging.

jacogr · 2017-02-24T11:21:48Z

As for the i18n comments, see my comments on the NL branch that went in - we need some extra checking tools, duplicates both ways, summary reports, etc. (However... once again, need to try and see if there are already existing helpers, we are not the first people with having to keep these updated)

For now keeping it as a manual process to run these until everything is sorted out. (Once manual goes 100%, can make that output part of the normal dev builds.)

* Add VaultMeta edit dialog * Updated (WIP) * Meta & password edit completed * Added SelectionList component for selections * Use SelectionList in DappPermisions * AddDapps uses SelectionList * Fix AccountCard to consistent height * Convert Signer defaults to SelectionList * Subtle selection border * Display account vault information * Allow invalid addresses to display icons (e.g. vaults) * Display vault on edit meta * Convert VaultAccounts to SelectionList * Allow editing of Vault in meta * Add tests for SectionList component * Add tests for VaultSelector component * Auto-focus description field (aligns with #4657) * Apply scroll fixes from lates commit in #4621 * Remove unneeded logs * Remove extra div, fixing ParityBar overflow * Disable save if password don't match * s/disabled/readOnly/ * string -> bool

* Render Dapps via SectionList * Initial rendering of accounts via SectionList * Width vars * Allow classNames in certifications & tags * Overlay of info on hover * Adjust hover balances * Large owner icons (align with vaults) * Consistent block mined at message * Attach ParityBackground to html * Adjust page padding to align * Lint fixes * Link to different types of addresses * Make content parts clickable only (a within a) * Force Chrome hardware acceleration * Trust the vendors... don't go crazy with transform :) * Use faster & default transitions * Add VaultMeta edit dialog * Updated (WIP) * Meta & password edit completed * Added SelectionList component for selections * Use SelectionList in DappPermisions * AddDapps uses SelectionList * Fix AccountCard to consistent height * Display type icons in creation dialog * Complimentary colours * Convert Signer defaults to SelectionList * Fix Geth import - actually pass addresses through * Work from addresses returned via RPC * Display actual addresses imported (not selected) * Update tests to cover bug fixed * Prettyfy Geth import * Description on selection actions * SelectionList as entry point * Update failing tests * Subtle selection border * Styling updates for account details * Add ModalBox summary * AddAddress updated * Display account vault information * Allow invalid addresses to display icons (e.g. vaults) * Display vault on edit meta * Convert VaultAccounts to SelectionList * Allow editing of Vault in meta * Add tests for SectionList component * Add tests for ModalBox component * Add tests for VaultSelector component * Add vaultsOpened in store * Add ~/ui/Form/VaultSelect * WIP * Fix failing tests * Move account to vault when selected * Fix circular build deps * EditMeta uses Form/VaultSelect * Vault move into meta store (alignment) * Re-apply stretch fix * Display vault in account summary * Add busy indicators to relevant modals * Auto-focus description field (aligns with #4657) * Remove extra container (double scrolling) * Remove unused container style * Apply scroll fixes from lates commit in #4621 * Remove unneeded logs * Remove extra div, fixing ParityBar overflow * Make dapp iframe background white * Stop event propgation on tag click * ChangeVault component (re-usable) * Use ChangeVault component * Pass vaultStores in * Icon highlight colour * Tag-ify vault name display * ChangeVault location * Bothced merge, selector rendering twice * Value can be undefined (no vault) * Close selector on Select bug * Fix toggle botched merge * Update tests * Add Vault Tags to Account Header

jacogr added 6 commits February 23, 2017 20:19

Shorten menu items (accounts)

f3be65a

Shorten menu items (addresses)

f3ee624

Shorten menu items (contracts)

11a4eb2

Shorten menu items (account)

caa5939

Shorten menu items (address)

867c1a1

Shorten menu items (contract)

d91b391

jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui labels Feb 23, 2017

jacogr added 11 commits February 23, 2017 21:07

Auto-focus & perform default action

58139ca

Auto-focus & default action

2e627f6

Auto focus for first fields (create account)

83ff283

Clear phrase & auto-focus field

37e4f12

Auto-focus name fields

357e36a

Add autoFocus (Add Address)

55739f2

autoFocus address (Add Contract)

7f10166

Auto focus name field

2a8e5ef

Auto-focus name field for EditMeta

1e5b551

Auto-focus modifications (WalletSettings)

2744025

Verification auto focus

ef83f77

jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Feb 23, 2017

jacogr added 2 commits February 24, 2017 07:49

typo

2bdb599

Merge branch 'master' into jg-misc-fixes

b6fd772

jacogr added a commit that referenced this pull request Feb 24, 2017

Auto-focus description field (aligns with #4657)

442b20c

ngotchac reviewed Feb 24, 2017

View reviewed changes

ngotchac added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 24, 2017

Double-up on keys

48bc27d

jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Feb 24, 2017

jacogr merged commit 0b21445 into master Feb 24, 2017

jacogr deleted the jg-misc-fixes branch February 24, 2017 11:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Misc. small UI fixes #4657

Misc. small UI fixes #4657

jacogr commented Feb 23, 2017 •

edited

Loading

ngotchac left a comment

ngotchac Feb 24, 2017

jacogr Feb 24, 2017

jacogr Feb 24, 2017

ngotchac Feb 24, 2017

jacogr Feb 24, 2017

jacogr commented Feb 24, 2017

jacogr commented Feb 24, 2017

Misc. small UI fixes #4657

Misc. small UI fixes #4657

Conversation

jacogr commented Feb 23, 2017 • edited Loading

ngotchac left a comment

Choose a reason for hiding this comment

ngotchac Feb 24, 2017

Choose a reason for hiding this comment

jacogr Feb 24, 2017

Choose a reason for hiding this comment

jacogr Feb 24, 2017

Choose a reason for hiding this comment

ngotchac Feb 24, 2017

Choose a reason for hiding this comment

jacogr Feb 24, 2017

Choose a reason for hiding this comment

jacogr commented Feb 24, 2017

jacogr commented Feb 24, 2017

jacogr commented Feb 23, 2017 •

edited

Loading