Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Custom dev chain presets #4671

Merged
merged 1 commit into from
Feb 24, 2017
Merged

Custom dev chain presets #4671

merged 1 commit into from
Feb 24, 2017

Conversation

keorn
Copy link

@keorn keorn commented Feb 24, 2017

Closes #4494
Seems to work as expected, all transactions get included.

@keorn keorn added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Feb 24, 2017
@gavofyork gavofyork merged commit 7a773b4 into master Feb 24, 2017
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 24, 2017
@gavofyork gavofyork deleted the custom-dev branch February 24, 2017 16:37
@rphmeier
Copy link
Contributor

rphmeier commented Feb 24, 2017

Seems to override user-specified CLI options? Defaults are good but restricting freedom isn't

@keorn
Copy link
Author

keorn commented Feb 24, 2017

Docs will contain a warning that --chain dev is a special preset. Otherwise per Engine defaults would be needed, which would require larger changes to the current setup.

@rphmeier
Copy link
Contributor

rphmeier commented Feb 24, 2017

(logged as separate issue)

I think this might make sense to do as "preset" configs that could come bundled with Parity so we don't have to mess around with ugly if-else stuff. So you could just run parity preset dev == parity --chain dev ... but overidden with any following flags.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants