Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Update Settings/Proxy view to match entries in proxy.pac #4771

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

bjornwgnr
Copy link
Collaborator

Replaces 'home.parity' with 'parity.web3.site' in Settings/Proxy view

@gavofyork
Copy link
Contributor

not actually true any more - we bought web3.site so it all just works, as long as they go to 8081. the entire proxy.pac thing needs removing completely.

@gavofyork gavofyork added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. M7-ui labels Mar 6, 2017
@tomusdrw
Copy link
Collaborator

tomusdrw commented Mar 6, 2017

Sort of. If we switch to support only domain-based access using proxy.pac will be necessary to easily support remote-accesed nodes (other options include altering /etc/hosts file or setting up local DNS entry).

I would keep it for now and re-visit that when #4474 is being done.

@parity-cla-bot
Copy link

It looks like @bjornwgnr signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@debris debris added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Jul 30, 2017
@debris
Copy link
Collaborator

debris commented Jul 30, 2017

@tomusdrw any update on this?

@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Aug 2, 2017
@tomusdrw
Copy link
Collaborator

tomusdrw commented Aug 2, 2017

The page is still there and proxy.pac is still supported so best to update it.

@gavofyork gavofyork merged commit e128285 into openethereum:master Aug 9, 2017
@gavofyork gavofyork removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Aug 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants