This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
eth_sign where account === undefined #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good to have a test case for |
tomusdrw
reviewed
Mar 20, 2017
| @@ -27,7 +27,7 @@ import styles from './transactionPendingFormConfirm.css'; | |||
|
|
|||
| export default class TransactionPendingFormConfirm extends Component { | |||
| static propTypes = { | |||
| account: PropTypes.object.isRequired, | |||
| account: PropTypes.object, | |||
There was a problem hiding this comment.
Perhaps you can use defaultProps instead of account &&?
There was a problem hiding this comment.
The funny thing here was that (a) the isRequired was not true & (b) the tests actually covered up the failure. But yes, making it default empty is probably a better approach than checking each access.
Will update, thanks.
ngotchac
added
A8-looksgood 🦄
jacogr
added a commit
that referenced
this pull request
Mar 22, 2017
* Update for case where account === undefined
* Update tests to not mask account === undefined
* default account = {} where undefined (thanks @tomusdrw)
Merged
arkpar
pushed a commit
that referenced
this pull request
Mar 22, 2017
* [ci skip] js-precompiled 20170314-121823 * Attach hardware wallets already in addressbook (#4912) * Attach hardware wallets already in addressbook * Only set values changed * Add Vaults logic to First Run (#4894) (#4914) * Add ability to configure Secure API (for #4885) (#4922) * Add z-index to small modals as well (#4923) * eth_sign where account === undefined (#4964) * Update for case where account === undefined * Update tests to not mask account === undefined * default account = {} where undefined (thanks @tomusdrw) * Fix Password Dialog forms style issue (#4968)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4962