This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
SecretStore: encrypt messages using private key from key store #6146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
A3-inprogress ⏳
|
inprogress because #6107 is also inprogress |
svyatonik
added
A0-pleasereview 🤓
|
This PR is for last 6 commits only |
debris
reviewed
Aug 8, 2017
ethstore/src/lib.rs
Outdated
| @@ -35,6 +35,7 @@ extern crate ethcore_bigint as bigint; | |||
| extern crate ethcrypto as crypto; | |||
| extern crate ethkey as _ethkey; | |||
| extern crate parity_wordlist; | |||
| extern crate ethcore_util as util; | |||
There was a problem hiding this comment.
I can't see where it's used. Isn't it redundant? Besides that ethstore is also compiled for android and ios. Bringing util dependency here, breaks that.
There was a problem hiding this comment.
Thanks. Checked it again - ethstore compiles without it. Looks like an artifact of some experiment. Will update PR
ethstore/src/ethstore.rs
Outdated
| fn agree(&self, account: &StoreAccountRef, password: &str, other: &Public) -> Result<Secret, Error> { | ||
| let accounts = self.get_matching(account, password)?; | ||
| for account in accounts { | ||
| return account.agree(password, other); |
There was a problem hiding this comment.
imo, it would be more idiomatic to write
match accounts.first() {
Some(ref account) => account.agree(password, other),
None => Err(Error::InvalidPassword),
}There was a problem hiding this comment.
also fixed couple of other functions above
debris
added
A5-grumble 🔥
svyatonik
added
A0-pleasereview 🤓
debris
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #6107
closes #5502
Previously secret key, used to encrypt communication between two nodes was stored as plain text in parity configuration file. Now you can use secret key of any account from key store (similar to
--engine-signeras Peter suggested). Previous configuration is also compatible - if len(configuration_file.secretstore.self_secret) == 64, then it is parsed as plain-text secret, if len is equal to 40, then it is parsed as account' address && password for this account is required (configuration_file.account.password).