This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
price-info does not depend on util #6231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
tomusdrw
reviewed
Aug 4, 2017
util/fetch/src/client.rs
Outdated
| @@ -297,7 +297,7 @@ impl Response { | |||
|
|
|||
| /// Returns `true` if response status code is successful. | |||
| pub fn is_success(&self) -> bool { | |||
| self.status() == reqwest::StatusCode::Ok | |||
| self.status().is_success() | |||
There was a problem hiding this comment.
Why was this changed? AFAIR is_sucess() returns true for any 2xx status code and I think we should be more strict in that case.
There was a problem hiding this comment.
I see, will revert it
|
CI fail is unrelated |
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tiny pr,