This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
WASM math test #6305
Merged
WASM math test #6305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NikVolf
commented
Aug 15, 2017
NikVolf
commented
- auxiliary runtime changes
NikVolf
added
A3-inprogress ⏳
NikVolf
added
A0-pleasereview 🤓
rphmeier
added
A8-looksgood 🦄
rphmeier
reviewed
Aug 18, 2017
| let x2 = context.value_stack.pop_as::<i32>()?; | ||
|
|
||
| let result = ((Runtime::bswap_32(x2 as u32) as u64) << 32 | ||
| | Runtime::bswap_32(x1 as u32) as u64) as i64; |
There was a problem hiding this comment.
is that actually how it's supposed to work?
[a b c d e f g h] -> [d c b a h g f e]
instead of [h g f e d c b a]
There was a problem hiding this comment.
Stack reverses the parameter ordering, so first parameter is popped last
lexfrl
reviewed
Aug 20, 2017
| @@ -414,3 +414,37 @@ fn storage_read() { | |||
| assert_eq!(gas_left, U256::from(99682)); | |||
| assert_eq!(Address::from(&result[12..32]), address); | |||
| } | |||
|
|
|||
|
|
|||
| // Tests that contract's ability to read from a storage | |||
There was a problem hiding this comment.
looks like there should be a different commentary..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.