Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add language selector in production #6317

Merged
merged 4 commits into from
Sep 5, 2017
Merged

Add language selector in production #6317

merged 4 commits into from
Sep 5, 2017

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Aug 16, 2017

This adds the language selector on production.

We might want to have complete translations before merging it though.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Aug 16, 2017
@ngotchac ngotchac requested review from jacogr and bjornwgnr August 16, 2017 15:54
@jacogr
Copy link
Contributor

jacogr commented Aug 28, 2017

Related #6378

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 5, 2017
@gavofyork gavofyork merged commit a62238c into master Sep 5, 2017
@gavofyork gavofyork deleted the ng-language-selector branch September 5, 2017 11:26
@gavofyork
Copy link
Contributor

gavofyork commented Sep 5, 2017

merging primarily because there's little point in keeping it as PR until UI2 is ready, however in general i'd prefer to keep any updates to the UI to be strictly those that are needed for security or usability.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants