This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Itertools are no longer reexported from util, optimized triedb iter #6322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
tomusdrw
reviewed
Aug 18, 2017
util/src/trie/triedb.rs
Outdated
| @@ -293,7 +292,17 @@ impl<'a> TrieDBIterator<'a> { | |||
| /// The present key. | |||
| fn key(&self) -> Bytes { | |||
| // collapse the key_nibbles down to bytes. | |||
| self.key_nibbles.iter().step(2).zip(self.key_nibbles.iter().skip(1).step(2)).map(|(h, l)| h * 16 + l).collect() | |||
| unsafe { | |||
There was a problem hiding this comment.
Does it really require such big block of unsafe code to be fast?
what about:
let nibbles = self.key_nibbles;
let len = nibbles.len() - 1;
let mut i = 0;
while i < len {
result.push(nibbles[i] * 16 + nibbles[i + 1]);
i += 2;
}
There was a problem hiding this comment.
maybe the checked indexing is too slow? i would guess that using unsafe only for get_unchecked would be good enough.
|
LGTM other than @tomusdrw grumble |
rphmeier
added
A5-grumble 🔥
debris
added
A0-pleasereview 🤓
arkpar
reviewed
Aug 21, 2017
util/src/trie/triedb.rs
Outdated
| let nibbles = &self.key_nibbles; | ||
| let mut i = 0; | ||
| let mut result = Bytes::with_capacity(nibbles.len() / 2); | ||
| let len = nibbles.len() - 1; |
There was a problem hiding this comment.
Is there a guarantee that nibbles is never empty and this can't underflow?
There was a problem hiding this comment.
no, just pushed a fix for that
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triedb benches
old:
new: