This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
Pull request needs code review.
B0-patch
M4-core ⛓
Core client code / Rust.
labels
Aug 21, 2017
CI timed out again. Getting this, error message sounds super weird:
Should be probably Not sure if this is related, but never noticed this earlier. Once the snapshot restoration fails, the total amount of requested snapshots increases:
|
arkpar
force-pushed
the
block-limits
branch
2 times, most recently
from
August 21, 2017 15:03
c5e0c2e
to
677e2d0
Compare
rphmeier
reviewed
Aug 22, 2017
ethcore/src/ethereum/ethash.rs
Outdated
const SNAPSHOT_BLOCKS: u64 = 30000; | ||
const SNAPSHOT_BLOCKS: u64 = 5000; | ||
/// Maximum number of blocks allowed in an ethash snapshot. | ||
const MAX_SNAPSHOT_BLOCKS: u64 = 300000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it meant to be 30k or 300k?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
rphmeier
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Aug 22, 2017
debris
approved these changes
Aug 22, 2017
closes #6297 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.