Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Only keep a single rocksdb debug log file #6346

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Aug 21, 2017

Closes #1100

Before:

db $ ls -l LOG*
-rw-r--r-- 1 user users 19001 Aug 21 15:31 LOG.old.1503322205093659
-rw-r--r-- 1 user users 85319 Aug 21 15:30 LOG.old.1503322205071345
-rw-r--r-- 1 user users 88637 Aug 21 15:29 LOG.old.1503322116371839
-rw-r--r-- 1 user users 32292 Aug 21 15:27 LOG.old.1503321102269360
-rw-r--r-- 1 user users 69247 Aug 21 15:32 LOG

After:

db $ ls -l LOG*
-rw-r--r-- 1 user users 67999 Aug 21 15:32 LOG

Rationale:

  • There is no documented way to disable the debug/info logging of rocksdb.
  • Setting the number of logs to 1 is the cleanest and simplest way to get close to disabling the logs.
  • 0 log files is not allowed (out of range error).
  • alternatives would involve hacky solutions like piping the logs to /dev/null
  • KISS, because we consider replacing rocksdb in the long run

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Aug 21, 2017
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 21, 2017
@debris debris merged commit 6e8f976 into master Aug 22, 2017
@debris debris deleted the a5-rocksdb-logging branch August 22, 2017 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable RocksDB debug logging
2 participants