This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Wasm math tests extended #6354
Merged
Wasm math tests extended #6354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
added
A0-pleasereview 🤓
arkpar
reviewed
Aug 28, 2017
| @@ -415,36 +415,121 @@ fn storage_read() { | |||
| assert_eq!(Address::from(&result[12..32]), address); | |||
| } | |||
|
|
|||
| macro_rules! reqrep_test { | |||
There was a problem hiding this comment.
This could be just a function that accepts code and input
There was a problem hiding this comment.
but it in turn uses macro, and the testfile content should be known at compile time, no runtime loading there
There was a problem hiding this comment.
Right, that's exactly why I was suggesting making testfile content (code) an argument to the function.
arkpar
added
A6-mustntgrumble 💦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.