This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Permissioned p2p connections #6359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
added
A0-pleasereview 🤓
keorn
added
the
B7-releasenotes 📜
arkpar
force-pushed
the
node-contract
branch
2 times, most recently
from
87790a4 to
cc374da
Compare
rphmeier
reviewed
Aug 24, 2017
ethcore/node_filter/src/lib.rs
Outdated
| /// Connection filter that uses a contract to manage permissions. | ||
| pub struct NodeFilter { | ||
| contract: Mutex<Option<Contract>>, | ||
| client: Weak<Client>, |
There was a problem hiding this comment.
any reason why not a Weak<BlockChainClient>?
light client support probably doesn't make sense for this, since generally light clients only initiate outgoing connections as opposed to accepting incoming
rphmeier
reviewed
Aug 24, 2017
| fn connection_allowed(&self, own_id: &NodeId, connecting_id: &NodeId, _direction: ConnectionDirection) -> bool { | ||
|
|
||
| let mut cache = self.permission_cache.lock(); | ||
| if let Some(res) = cache.get(connecting_id) { |
There was a problem hiding this comment.
should it be memory bounded somehow?
rphmeier
reviewed
Aug 24, 2017
ethcore/node_filter/src/lib.rs
Outdated
| #[cfg(test)] | ||
| mod test { | ||
|
|
||
| use std::sync::Arc; |
There was a problem hiding this comment.
tests module code needs indenting
rphmeier
reviewed
Aug 24, 2017
|
|
||
| let mut contract = self.contract.lock(); | ||
| if contract.is_none() { | ||
| *contract = Some(Contract::new(self.contract_address)); |
There was a problem hiding this comment.
i don't see the purpose of this. we have the address at initialization, so why not just create the contract structure there?
There was a problem hiding this comment.
i guess it just defers ABI-decoding a bit?
There was a problem hiding this comment.
right, just deferred initialization that could save some time in offline mode.
|
Grumbles about contract wrapper, otherwise LGTM |
rphmeier
added
A5-grumble 🔥
arkpar
added
A0-pleasereview 🤓
rphmeier
reviewed
Aug 29, 2017
| "0000000000000000000000000000000000000004": { "balance": "1", "builtin": { "name": "identity", "pricing": { "linear": { "base": 15, "word": 3 } } } }, | ||
| "0000000000000000000000000000000000000005": { | ||
| "balance": "1", | ||
| "constructor": "6060604052341561000f57600080fd5b5b6012600102600080601160010260001916815260200190815260200160002081600019169055506022600102600080602160010260001916815260200190815260200160002081600019169055506032600102600080603160010260001916815260200190815260200160002081600019169055506042600102600080604160010260001916815260200190815260200160002081600019169055505b5b610155806100bd6000396000f30060606040526000357c0100000000000000000000000000000000000000000000000000000000900463ffffffff168063994d790a1461003e575b600080fd5b341561004957600080fd5b61008a6004808035600019169060200190919080356000191690602001909190803560001916906020019091908035600019169060200190919050506100a4565b604051808215151515815260200191505060405180910390f35b60006001800285600019161480156100c3575060026001028460001916145b156100d15760019050610121565b60006001028360001916141580156100f157506000600102826000191614155b801561011e5750816000191660008085600019166000191681526020019081526020016000205460001916145b90505b9493505050505600a165627a7a723058202082b8d8667fd397925f39785d8e804540beda0524d28af15921375145dfcc250029" |
rphmeier
reviewed
Aug 29, 2017
| use io::IoChannel; | ||
| use super::NodeFilter; | ||
|
|
||
| /// Contract code: https://gist.github.com/arkpar/467dbcc73cbb85b0997a7a10ffa0695f |
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.