This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Added missing SecretStore tests - signing session #6411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
A0-pleasereview 🤓
NikVolf
reviewed
Sep 2, 2017
| @@ -85,7 +85,7 @@ struct SessionData { | |||
| } | |||
|
|
|||
| /// Signing session state. | |||
| #[derive(Debug, PartialEq)] | |||
| #[derive(Debug, PartialEq, Clone, Copy)] | |||
There was a problem hiding this comment.
could be #[cfg_attr(test, derive(Clone, Copy))]
NikVolf
reviewed
Sep 2, 2017
| #[cfg(test)] | ||
| /// Get consensus job reference. |
There was a problem hiding this comment.
i think according to our style, the previous variant was correct (attribute after doc comment)
Not sure doc comment is needed for test item anyway though
NikVolf
added
A6-mustntgrumble 💦
NikVolf
reviewed
Sep 2, 2017
| #[test] | ||
| fn does_not_fail_when_consensus_message_received_after_consensus_established() { | ||
| let (_, mut sl) = prepare_signing_sessions(1, 3); | ||
| sl.master().initialize(777.into()).unwrap(); |
There was a problem hiding this comment.
could use other than 777 in some tests, to disallow future contributions taking shortcuts to pass tests
NikVolf
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bjornwgnr I have planned another couple of tests to add, will do this in next PRs.