This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
triehash is separated from util #6428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
NikVolf
reviewed
Sep 2, 2017
| @@ -23,7 +23,7 @@ use hash::keccak; | |||
| use views::BlockView; | |||
| use rlp::{DecoderError, RlpStream, UntrustedRlp}; | |||
| use util::{Bytes, H256}; | |||
| use util::triehash::ordered_trie_root; | |||
| use triehash::ordered_trie_root; | |||
There was a problem hiding this comment.
used only once in the code, could be referenced by global path instead of use, as in the test
There was a problem hiding this comment.
Is there some rules for the usage of use in parity project? (it currently seems not though)
For example:
- make the self-host libs a group and third party libs a group
- sort it alphabetically within the group
- make it clear when to use
* - make it clear when to use global path
- others
I think we can make those rules in the CONTRIBUTION.md and make contributors to follow those rules.
There was a problem hiding this comment.
We don't have such rules currently, although I totally agree that we should have them
NikVolf
added
A6-mustntgrumble 💦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #6418