This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
light-poa round 2: allow optional casting of engine client to full client #6468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
rphmeier
force-pushed
the
light-poa-2
branch
from
9b2f0ec to
7d1c7a0
Compare
|
@arkpar only the diff of the last 2 commits is important. the rest is just the changes you've looked at before. |
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TX filter will now only allow transactions on full nodes by attempting to upgrade the
EngineClient. But I still don't think that this logic belongs in the consensus layer at all.