This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
SecretStore: ShareRemove of 'isolated' nodes #6630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a fix of TODO4 from #6605
The case is:
In current implementation every node that have a share of given key, must participate in any admin session with this key. Obviously, it is impossible in this case, because node(s) is already 'isolated' from cluster.
So the idea is to give ability to run admin sessions even if some owners of shares are already isolated:
Since in (1) session is started explicitely by administrator && in (3) only isolated nodes which are not in new_nodes_set are removed, we may assume that isolated node is not going to return.
But this case (re-addition of isolated node to the cluster) should be taken into account when working on TODO#3 from #6605.