This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Light Client: fetch transactions/receipts by transaction hash #6641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching a transaction (for RPC) by hash is different than all other requests because it requires information about the block to be included in the RPC result. The same goes for receipts. This means that we have to request more data after receiving the response before we can check its validity.
Implemented now with a
TransactionIndex
request. This returns a(block number, block hash, index)
tuple. The block is fetched, checked for existence in the local chain, and then searched for the transaction. If we are fetching a receipt, the block receipts are then fetched and the receipt is extracted.Using the trie roots in the header might be a better approach, but for now repeat requests will mostly draw from cached data and will not have to go to the network for anything heavy.
Also makes light protocol request cost table parsing more lenient, allowing some request types to be present while others might not be. This allows for easy backwards-compatible extension of the light protocol with new request types.