Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Separate migrations from util #6690

Merged
merged 11 commits into from
Oct 10, 2017
Merged

Separate migrations from util #6690

merged 11 commits into from
Oct 10, 2017

Conversation

debris
Copy link
Collaborator

@debris debris commented Oct 10, 2017

based on #6573
closes #6418

In #6573 @Hawstein wrote:

separate migration from util and make its dependencies into libs:

  • snappy
  • kvdb
  • error
  • common

I applied few additional changes:

  • renamed /common -> macros, cause this crate provides only macros
  • renamed ethcore_error -> util_error, cause the name is misleading
  • kvdb does not use util_error any longer. instead it provides it's own error type
  • util_error no longer depends on snappy. conversion from snappy error was not used anyway
  • merged nibbleslice and nibblesvec into patricia_trie crate. there is no need to keep them separated
  • removed unused imports

TODO (will open issue accordingly, after this pr is merged):

  • kvdb should be separated into 2 separate crates: kvdb and kvrocksdb which implements key-value interface for rocksdb
  • journal crate should be separated from util. overlaydb and util_error crate should be merged into it. also UtilError should be just renamed to Error.
  • cache should be separated from util
  • util should be dissolved

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 10, 2017
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 10, 2017
@debris debris merged commit 6279ff3 into master Oct 10, 2017
@debris debris deleted the separate-migrations-from-util branch October 10, 2017 18:02
@5chdn 5chdn mentioned this pull request Oct 10, 2017
67 tasks
@5chdn 5chdn added this to the 1.8 milestone Oct 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue util refactor
4 participants