This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #6573
closes #6418
In #6573 @Hawstein wrote:
I applied few additional changes:
/common
->macros
, cause this crate provides only macrosethcore_error
->util_error
, cause the name is misleadingkvdb
does not useutil_error
any longer. instead it provides it's own error typeutil_error
no longer depends on snappy. conversion from snappy error was not used anywaynibbleslice
andnibblesvec
intopatricia_trie
crate. there is no need to keep them separatedTODO (will open issue accordingly, after this pr is merged):
kvdb
should be separated into 2 separate crates:kvdb
andkvrocksdb
which implements key-value interface for rocksdbjournal
crate should be separated from util.overlaydb
andutil_error
crate should be merged into it. alsoUtilError
should be just renamed toError
.cache
should be separated fromutil
util
should be dissolved