Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bench-bot: Merge the target branch into the current branch before running benchmarks #40

Closed
joao-paulo-parity opened this issue May 12, 2022 · 1 comment
Closed

bench-bot: Merge the target branch into the current branch before running benchmarks #40

joao-paulo-parity opened this issue May 12, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@joao-paulo-parity
Copy link
Contributor

joao-paulo-parity commented May 12, 2022 •
edited
Loading

Restore the behavior of https://github.com/paritytech/bench-bot/blob/cd3b2943d911ae29e41fe6204788ef99c19412c3/bench.js#L128 to https://github.com/paritytech/pipeline-scripts/blob/master/bench-bot.sh

Note: it should be the target branch of the PR, i.e. not always master. This remark is related to paritytech/bench-bot#75 and paritytech/polkadot#4564 (comment).
@joao-paulo-parity joao-paulo-parity added the enhancement New feature or request label May 12, 2022
@joao-paulo-parity joao-paulo-parity changed the title Merge master into the current branch before running bench-bot benchmarks bench-bot: Merge master into the current branch before running benchmarks May 12, 2022
@joao-paulo-parity joao-paulo-parity changed the title bench-bot: Merge master into the current branch before running benchmarks bench-bot: Merge the target branch into the current branch before running benchmarks May 12, 2022
@joao-paulo-parity
Copy link
Contributor Author

done in eb9c664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joao-paulo-parity