Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRAME] VersionedCall #1138

Open
xlc opened this issue Nov 27, 2022 · 2 comments
Open

[FRAME] VersionedCall #1138

xlc opened this issue Nov 27, 2022 · 2 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. I4-refactor Code needs refactoring.

Comments

@xlc
Copy link
Contributor

xlc commented Nov 27, 2022

Previous discussion paritytech/substrate#12740 (comment)

We should introduce a VersionedCall that's opaque Call + transaction_version and it can validate stored transaction_version with current version and report error on mismatching.

And replace all stored calls to use VersionedCall to prevent unexpected bad execution due to breaking transaction version.
@ggwpez ggwpez transferred this issue from paritytech/substrate Aug 25, 2023
@ggwpez ggwpez added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I4-refactor Code needs refactoring. labels Mar 13, 2024
@ggwpez ggwpez changed the title VersionedCall [FRAME] VersionedCall Mar 13, 2024
@xlc xlc mentioned this issue Apr 8, 2024
Open
@0xsouravm
Copy link

Hello! I would like to take this up with your help. Is this still available?

@xlc
Copy link
Contributor Author

xlc commented Dec 13, 2024 •
edited
Loading

I don't think anyone else is working on this so it is available
But before you start coding, please share here how you plan to implement this just so we can help to ensure it is on the right direction.
The last thing I want to see is you make a huge PR making breaking changes to 5 pallets

@paritytech paritytech deleted a comment from asggWa Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. I4-refactor Code needs refactoring.
Projects
Runtime / FRAME
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xlc @ggwpez @0xsouravm