[Deprecation] Deprecate Gov1 pallets

[juangirini]

Motivated by the conversation started in paritytech/substrate#14241 (comment) Gov1 pallets should be deprecated

Pallets to deprecate

Preview Give feedback

1. Tips
2. Democracy

They should follow the Deprecation Process.

[juangirini]

@kianenigma @ggwpez what's the full list of Gov1 pallets?

[juangirini]

This is related to #485

[liamaharon]

@kianenigma @ggwpez what's the full list of Gov1 pallets?

• elections-phragmen
• democracy
• tips
• collective
• membership

[liamaharon]

noting here a possible deprecating strategy for these suggested by Gav:

Mark as deprecated and remove in 6 months; best to include the date for removal in the #[deprecated = "..."] message.

[juangirini]

This suggestion by Gav is already covered in the deprecation process, except for the date note that I will add.

[kianenigma]

@kianenigma @ggwpez what's the full list of Gov1 pallets?

• elections-phragmen
• democracy
• tips
• collective
• membership

Isn't things like collective and membership are still being used? Best is to check the Kusama runtime and see what pallets are still in there as a part of the governance process.

[liamaharon]

@kianenigma @ggwpez what's the full list of Gov1 pallets?

• elections-phragmen
• democracy
• tips
• collective
• membership

Isn't things like collective and membership are still being used? Best is to check the Kusama runtime and see what pallets are still in there as a part of the governance process.

Yup I checked. All instances of pallet_collective and pallet_membership were removed from the Kusama runtime in this PR paritytech/polkadot#6701

[kianenigma]

But they might be still used in system parachains such as

https://github.com/paritytech/cumulus/blob/d20c4283fe85df0c1ef8cb7c9eb7c09abbcbfa31/parachains/runtimes/collectives/collectives-polkadot/src/lib.rs#L460

All in all, I would argue that between the 5, collective and membership are more useful as independent building-blocks that can be used outside the context of a governance system as well, so if any of them is to still receive support, it should be these two.

Moreover, paritytech/substrate#12588 will make elections-phragmen into a generic election pallet, and it can always be a nice addition to collectives.

Contrary, while we have the gov v2 pallets, something like pallet-governance has less reason to exist.

All in all, i think tips and democracy should go, elections maybe, the rest we should keep.

[liamaharon]

I see what you mean now, thanks for clarifying 👍

[xlc]

Can we have some process for such ecosystem wide impact breaking changes? I can’t be just an informal decision from a few devs. It can be a formal decision from a few devs if there is a formal process used with documents of the process.

Yeah I know there will be a depreciation process and I am sure someone will notify you if you deprecated that something shouldn’t be depreciated, but still, how do you decide what should be depreciated?

Besides, there are many other less used pallets in FRAME. Have you considered remove those first? e.g. atomic-swap, insecure-randomness-collective-flip, lottery, nicks.

[juangirini]

As mentioned in the issue description there is indeed a deprecation process for this #182.

We are indeed working on improving processes and documenting them, but of course there is still a lot of work to be done. All constructive suggestions are welcome.

There might be other deprecations in the future, this issues is about Gov1.

[xlc]

I am asking for the process to determine what pallet to remove from this repo and apply this process to less used pallets first before gov1 pallets. This process happens before the deprecation process. Or in other words, the deprecation process is only a step in this pallet removal process.

[juangirini]

@muharem could you please check the list of pallets to deprecate?

[muharem]

@juangirini I can only add that pallet_collectives used in Collectives parachain, which we can migrate.
the list corresponds to what we removed/removing with integrating Gov2.
and I agree with what was said above, we should not remove the pallets from substrate just because they are not used in polkadot/kusama runtimes anymore. There is should be an alternative (democracy -> referenda) or another reason.

[juangirini]

Gov1 pallets that have a Gov2 alternative will be deprecated and eventually archived. Any team external to Parity will be free to clone that repo and maintain it.