Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PVF: Incorporate wasmtime version in worker version checks #2398

Closed
mrcnski opened this issue Nov 19, 2023 · 1 comment
Closed

PVF: Incorporate wasmtime version in worker version checks #2398

mrcnski opened this issue Nov 19, 2023 · 1 comment
Assignees
@mrcnski
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T0-node This PR/Issue is related to the topic “node”.

Comments

@mrcnski
Copy link
Contributor

mrcnski commented Nov 19, 2023

For example, say someone downloads the node and workers at a release version, and then switches to master for some bug fixes. He could be running an updated node without updating the workers, but the node version hasn't changed so the version check passes. But wasmtime may have been bumped since then.

Wasmtime bumps are rare enough, that we can enforce rebuilds without impacting the dev UX. Should be simple to implement; see the new SUBSTRATE_WASMTIME_VERSION env var.

Originally posted by @mrcnski in #1918 (comment)
@mrcnski mrcnski added T0-node This PR/Issue is related to the topic “node”. C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. labels Nov 19, 2023
@mrcnski mrcnski self-assigned this Dec 18, 2023
@mrcnski mrcnski moved this to In Progress in parachains team board Dec 18, 2023
@mrcnski mrcnski mentioned this issue Dec 18, 2023
Closed
@s0me0ne-unkn0wn s0me0ne-unkn0wn mentioned this issue Jan 30, 2024
Closed
@s0me0ne-unkn0wn
Copy link
Contributor

Closing as superseded by #3139

@github-project-automation github-project-automation bot moved this from In Progress to Completed in parachains team board Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrcnski mrcnski

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T0-node This PR/Issue is related to the topic “node”.
Projects
parachains team board
Status: Completed
PVF Security Hardening
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PVF: Incorporate wasmtime version in worker version checks paritytech/polkadot-sdk
2 participants
@mrcnski @s0me0ne-unkn0wn