Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rococo not warp-syncable #3177

Closed
girazoki opened this issue Feb 1, 2024 · 2 comments
Closed

Rococo not warp-syncable #3177

girazoki opened this issue Feb 1, 2024 · 2 comments

Comments

@girazoki
Copy link
Contributor

girazoki commented Feb 1, 2024

I know an issue had been posted in the past about this (#1148), but we are having a similar issue on an internal relay and I would like to get more insight on this. When I try to warp sync rococo I get the following logs

08.165 DEBUG tokio-runtime-worker sync: Importing warp proof data from 12D3KooWJhwBW1UjxhxHaCUCWYmCRjsWx6ZEbwHTqfQmPjNx8GjC, 2992652 bytes.    
2024-02-01 17:54:08.589 DEBUG tokio-runtime-worker sync: Bad warp proof response: bad justification for header: invalid commit in grandpa justification    
2024-02-01 17:54:08.589 DEBUG tokio-runtime-worker sync: Bad proof data received from 12D3KooWJhwBW1UjxhxHaCUCWYmCRjsWx6ZEbwHTqfQmPjNx8GjC    
2024-02-01 17:54:08.589 TRACE tokio-runtime-worker sync: New WarpProofRequest for 12D3KooWJhwBW1UjxhxHaCUCWYmCRjsWx6ZEbwHTqfQmPjNx8GjC    
2024-02-01 17:54:08.589 TRACE tokio-runtime-worker sync: Processed DropPeer(BadPeer(PeerId("12D3KooWJhwBW1UjxhxHaCUCWYmCRjsWx6ZEbwHTqfQmPjNx8GjC"), ReputationChange { value: -536870912, reason: "Bad block" })).

It says Bad warp proof response: bad justification for header: invalid commit in grandpa justification . I am wondering if this is related to a consensus failure (or a finality lag) that was solved by doing grandpa->note_stalled, which (AFAIK) forces the current set of authorities to finalize a block for which potentially they were not authorities of.

We had to do this a couple of times in our internal relay and I wonder whether this is the reason not to be able to warp sync it (and also the reason why it is not working in rococo).

If so, is this even fixable?

@girazoki
Copy link
Contributor Author

girazoki commented Feb 1, 2024

BTW I tried to warp sync rococo with the 1.6.0 polkadot binary

@bkchr
Copy link
Member

bkchr commented Feb 1, 2024

We have done forced set changes of the validator set. This breaks warp syncing.

#12 will fix this. As I see this issue as a duplicate, I'm closing it.

@bkchr bkchr closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants