Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The node should shutdown if SyncingEngine event loop terminates #3561

Open
dmitry-markin opened this issue Mar 4, 2024 · 1 comment
Open
Labels
I2-bug The node fails to follow expected behavior.

Comments

@dmitry-markin
Copy link
Contributor

As #3496 demonstrates, when fatal error happens in SyncingEngine and its event loop terminates, the node continues running. This is not a correct behavior, as it doesn't make sense to run the node without syncing. Instead, the entire node should shutdown.

@dmitry-markin dmitry-markin added the I2-bug The node fails to follow expected behavior. label Mar 4, 2024
@altonen
Copy link
Contributor

altonen commented Mar 4, 2024

Maybe SyncingEngine could be started with spawn_essential() or Notifications could return a fatal error if one of the protocol command streams is closed, shutting down NetworkWorker which would probably shut down the rest of the node as well.

@dmitry-markin dmitry-markin changed the title Parachain node should shutdown if SyncingEngine event loop terminates The node should shutdown if SyncingEngine event loop terminates Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior.
Projects
Status: No status
Development

No branches or pull requests

2 participants