Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose NominationPools::MaxUnbonding as a pallet constant #422

Closed
2 tasks done
valentunn opened this issue Mar 21, 2023 · 0 comments
Closed
2 tasks done

Expose NominationPools::MaxUnbonding as a pallet constant #422

valentunn opened this issue Mar 21, 2023 · 0 comments
Labels
I5-enhancement An additional feature request. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@valentunn
Copy link

valentunn commented Mar 21, 2023

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Motivation

Since MaxUnbonding is a configurable parameter, it might not always be aliased to Staking::MaxUnlockChunks as its done in Polkadot, Kusama, and Westend runtimes. For example, Aleph Zero defines it to be different than MaxUnlockChunks. Exposing it as a pallet constant would allow clients to query metadata to get this bit of information to perform client-side checks to avoid users loosing tokens on commission for extrinsic known to fail in advance.

Request

Expose `NominationPools::MaxUnbonding as pallet constant

Solution

Annotate type MaxUnbonding: Get<u32>; with #[pallet::constant]

Are you willing to help with this request?

Yes!

@valentunn valentunn changed the title Expose `NominationPools::MaxUnbonding as pallet constant Expose NominationPools::MaxUnbonding as pallet constant Mar 21, 2023
@valentunn valentunn changed the title Expose NominationPools::MaxUnbonding as pallet constant Expose NominationPools::MaxUnbonding as a pallet constant Mar 21, 2023
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I5-enhancement An additional feature request. I10-unconfirmed Issue might be valid, but it's not yet known. and removed J0-enhancement labels Aug 25, 2023
@rossbulat rossbulat moved this from 📕 Backlog to ✂️ In progress. in (Nominated) Proof of Stake Nov 19, 2023
@github-project-automation github-project-automation bot moved this from ✂️ In progress. to ✅ Done in (Nominated) Proof of Stake Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5-enhancement An additional feature request. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
Status: Done
Development

No branches or pull requests

3 participants