Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review bot: User's association is NONE #5244

Closed
ggwpez opened this issue Aug 5, 2024 · 2 comments
Closed

Review bot: User's association is NONE #5244

ggwpez opened this issue Aug 5, 2024 · 2 comments
Assignees

Comments

@ggwpez
Copy link
Member

ggwpez commented Aug 5, 2024

CI output from this merge request #5206.

cc @Bullrich

User's association is NONE
{"url":"https://api.github.com/repos/paritytech/polkadot-sdk/pulls/5206","id":1998719876,"node_id":"PR_kwDOKDT1Ss53IguE","html_url":"https://github.com/paritytech/polkadot-sdk/pull/5206","diff_url":"https://github.com/paritytech/polkadot-sdk/pull/5206.diff","patch_url":"https://github.com/paritytech/polkadot-sdk/pull/5206.patch","issue_url":"https://api.github.com/repos/paritytech/polkadot-sdk/issues/5206","number":5206,"state":"open","locked":false,"title":"Fix spelling issues","user":{"login":"nnsW3","id":146735585,"node_id":"U_kgDOCL8B4Q","avatar_url":"https://avatars.githubusercontent.com/u/146735585?v=4","gravatar_id":"","url":"https://api.github.com/users/nnsW3","html_url":"https://github.com/nnsW3","followers_url":"https://api.github.com/users/nnsW3/followers","following_url":"[https://api.github.com/users/nnsW3/following{/other_user}](https://api.github.com/users/nnsW3/following%7B/other_user%7D)","gists_url":"[https://api.github.com/users/nnsW3/gists{/gist_id}](https://api.github.com/users/nnsW3/gists%7B/gist_id%7D)","starred_url":"[https://api.github.com/users/nnsW3/starred{/owner}{/repo}](https://api.github.com/users/nnsW3/starred%7B/owner%7D%7B/repo%7D)","subscriptions_url":"https://api.github.com/users/nnsW3/subscriptions","organizations_url":"https://api.github.com/users/nnsW3/orgs","repos_url":"https://api.github.com/users/nnsW3/repos","events_url":"[https://api.github.com/users/nnsW3/events{/privacy}](https://api.github.com/users/nnsW3/events%7B/privacy%7D)","received_events_url":"https://api.github.com/users/nnsW3/received_events","type":"User","site_admin":false},"body":"Hello\r\nI found several spelling errors.\r\nBr, Elias.\r\n","created_at":"2024-08-01T14:50:48Z","updated_at":"2024-08-05T13:18:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0414ffa24a14018ddea2c86b0850f86498669d34","assignee":null,"assignees":[],"requested_reviewers":
...
@Bullrich Bullrich self-assigned this Aug 6, 2024
@Bullrich
Copy link
Contributor

Bullrich commented Aug 6, 2024

Hi @ggwpez! This is intended.

The user, who is not a member of /paritytech, pushed a new commit. As requested in paritytech/opstooling#174 we want every last commit pushed by non-members to be reviewed to stop them from pushing malicious code once they have enough approvals.

It copies this behaviour:
image

You can see the message (which appears only once) informing about this: #5206 (comment)

Let me know if there is anything else I can help with.

@ggwpez
Copy link
Member Author

ggwpez commented Aug 6, 2024

Ah okay. I immediately checked the log output and could not make sense of it, thanks!

@ggwpez ggwpez closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants