Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Open JoinPool canvas immediately, preloader, prioritise low member pools. #2059

Merged
merged 8 commits into from
Apr 5, 2024

Conversation

rossbulat
Copy link
Collaborator

@rossbulat rossbulat commented Apr 5, 2024

Improves pool joining UX by opening the JoinPool canvas immediately and displaying a preloading state within the canvas. This prevents the user having to click the "Join Pool" button twice, once to initiate the syncing process, and another time to open the canvas.

The user is still free to close the JoinPool canvas while the performance data is being fetched - it will continue and be ready when the user opens it again.

Breakdown of changes

  • New preloading state in JoinPool canvas while performance data is being fetched, with ability to open JoinPool immediately.
  • Added ability to disable ButtonTabs, with custom disabled styling.
  • Moved join pool loader animation to a separate styled component.
  • Optimise join pool selection to promote decentralisation.
    • Fetch the lower third of pools ordered by memberCounter.
    • Ensure pools have at least 2x the minimum active stake in points value (converting to balance would be extra overhead and time to process, deemed not necessary).
  • Misc polish.

@rossbulat rossbulat changed the title feat: Open JoinPool canvas immediately & preload performance data feat: Open JoinPool canvas immediately, preloader, prioritise low member pools. Apr 5, 2024
@rossbulat rossbulat merged commit 5360eaa into main Apr 5, 2024
11 checks passed
@rossbulat rossbulat deleted the rb-open-join-pool-immediately branch April 5, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants