Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

dispute-coordinator: Prioritization on best-effort queue is broken with batching #5896

Closed
eskimor opened this issue Aug 17, 2022 · 2 comments · Fixed by #6275
Closed

dispute-coordinator: Prioritization on best-effort queue is broken with batching #5896

eskimor opened this issue Aug 17, 2022 · 2 comments · Fixed by #6275
Assignees
Labels
T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.

Comments

@eskimor
Copy link
Member

eskimor commented Aug 17, 2022

With the upcoming batching of votes the logic for prioritizing participation requests on the best-effort queue is broken. I bumps up priority based on the number of times a candidate is added to the queue - which currently equals the number of times a vote is imported. With batched imports this is no longer true and needs to be fixed, e.g. by passing in the number of votes that have been imported for the request to happen.

@eskimor eskimor added Q0-trivial T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes. labels Aug 17, 2022
@ordian ordian moved this to To do in Parachains-core Aug 17, 2022
@eskimor
Copy link
Member Author

eskimor commented Sep 13, 2022

Even better, with the upcoming change in meaning what best-effort means, we can actually use the same mechanism as the priority queue and order based on block height of the relay parent. best-effort just becomes another instance of the same kind of queue.

@eskimor
Copy link
Member Author

eskimor commented Sep 13, 2022

There is one edge case though. We we stick with the ideas in the guide, then we also participate if the dispute got confirmed. In that case we would not know the relay parent. Such participation requests should be treated with the lowest priority.

@tdimitrov tdimitrov moved this from To do to In progress in Parachains-core Nov 12, 2022
@tdimitrov tdimitrov moved this from In progress to Review in progress in Parachains-core Nov 14, 2022
Repository owner moved this from Review in progress to Done in Parachains-core Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants