Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Verify that all weight files were updated #6906

Closed
ggwpez opened this issue Mar 17, 2023 · 1 comment
Closed

Verify that all weight files were updated #6906

ggwpez opened this issue Mar 17, 2023 · 1 comment
Assignees
Labels
I6-benchmarks Benchmarks need fixing, improving or augmenting. T8-release This PR/Issue is related to topics touching the release notes.

Comments

@ggwpez
Copy link
Member

ggwpez commented Mar 17, 2023

Before a release happens and after all weight files were supposed to be updated, we should run a script to double-check the modification date of all weight files. Actually it would be better to check the //! DATE: comment, since the last git modification date could be unrelated to the re-generation of the weights.
The script that we currently use to run all benchmarks is not ideal; there are situations that pallets can go amiss.

We can limit he check to runtime weight files. It should be enough to filter for
"THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI" through all files, but good to double check with this file glob runtime/*/src/weights/**/*.rs,bridges/modules/*/src/weights.rs.
PS: //! DATE: ([0-9]+-[0-9]+-[0-9]+) looks like a good pattern.

(Not sure where to best put this issue so consider this as place holder)
cc @bkontur @coderobe

@ggwpez ggwpez added T8-release This PR/Issue is related to topics touching the release notes. I6-benchmarks Benchmarks need fixing, improving or augmenting. labels Mar 17, 2023
@ggwpez ggwpez mentioned this issue Mar 17, 2023
@s3krit s3krit self-assigned this Mar 28, 2023
@s3krit
Copy link
Contributor

s3krit commented Apr 13, 2023

Closing as #6996 is now merged

@s3krit s3krit closed this as completed Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I6-benchmarks Benchmarks need fixing, improving or augmenting. T8-release This PR/Issue is related to topics touching the release notes.
Projects
None yet
Development

No branches or pull requests

2 participants