Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add missing migrations #7187

Closed
15 tasks done
ggwpez opened this issue May 5, 2023 · 5 comments · Fixed by #7251
Closed
15 tasks done

Add missing migrations #7187

ggwpez opened this issue May 5, 2023 · 5 comments · Fixed by #7251
Assignees
Labels
I3-bug Fails to follow expected behavior.

Comments

@ggwpez
Copy link
Member

ggwpez commented May 5, 2023

The following pallets have wrong on-chain version as reported by paritytech/substrate#13417 cc @bkchr.
CI output from here shows them #7186.
First we have to confirming manually that they are wrong, then we can include the correct ones.

@liamaharon
Copy link
Contributor

liamaharon commented May 17, 2023

Confirmed #7199 fixes all Polkadot & Kusama issues.

also confirmed the issues with Westend and Rococo, I'll jump on those tomorrow since they're causing on_runtime_upgrade to fail when run against those chains.

@liamaharon liamaharon added the U2-some_time_soon Issue is worth doing soon. label May 17, 2023
@ggwpez
Copy link
Member Author

ggwpez commented May 17, 2023

also confirmed the issues with Westend and Rococo, I'll jump on those tomorrow since they're causing on_runtime_upgrade to fail when run against those chains.

Yes Westend should be fixed by #7186 (PS: not anymore it seems 🤦‍♂️ ).
Rococo is busted though.

@liamaharon
Copy link
Contributor

I need to get more hands on experience with migrations, happy to take on fixing #7186

@ggwpez
Copy link
Member Author

ggwpez commented May 17, 2023

Yes please. I think i accidentally removed the changes that were supposed to fix Westend.
You can re-purpose it to just fix Westend. It seems like we are not going to skip .42 on Polkadot, so the backports are not needed.

@liamaharon
Copy link
Contributor

liamaharon commented May 18, 2023

Fixed in #7251 and paritytech/substrate#14174.

I'm not exactly how backports work @ggwpez or what's happening there, so I put the Westend and Rococo fixes on a new branch

@juangirini juangirini linked a pull request May 22, 2023 that will close this issue
@liamaharon liamaharon reopened this May 23, 2023
@juangirini juangirini removed the U2-some_time_soon Issue is worth doing soon. label May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I3-bug Fails to follow expected behavior.
Projects
Status: Done
3 participants