Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Polkadot v0.9.43 Release checklist #7286

Closed
14 tasks done
github-actions bot opened this issue May 24, 2023 · 14 comments
Closed
14 tasks done

Polkadot v0.9.43 Release checklist #7286

github-actions bot opened this issue May 24, 2023 · 14 comments
Assignees
@coderobe

Comments

@github-actions
Copy link

github-actions bot commented May 24, 2023 •
edited by coderobe
Loading

Release Checklist

This is the release checklist for Polkadot v0.9.43. All following
checks should be completed before publishing a new release of the
Polkadot/Kusama/Westend/Rococo runtime or client. The current release candidate can be
checked out with git checkout release-v0.9.43

Runtime Releases

These checks should be performed on the codebase prior to forking to a release-
candidate branch.

  • Verify spec_version has been incremented since the
    last release for any native runtimes from any existing use on public
    (non-private) networks. If the runtime was published (release or pre-release), either
    the spec_version or impl must be bumped.
  • Verify previously completed migrations are
    removed for any public (non-private/test) networks.
  • Verify pallet and extrinsic ordering has stayed
    the same. Bump transaction_version if not.
  • Verify new extrinsics have been correctly whitelisted/blacklisted for
    proxy filters.
  • Verify benchmarks have been updated for any modified
    runtime logic.

The following checks can be performed after we have forked off to the release-
candidate branch or started an additional release candidate branch (rc-2, rc-3, etc)

  • Verify new migrations complete successfully, and the
    runtime state is correctly updated for any public (non-private/test)
    networks.
  • Verify Polkadot JS API are up to date with the latest
    runtime changes.
  • Check with the Signer's team to make sure metadata update QR are lined up
  • Push runtime upgrade to Westend and verify network stability.

All Releases
@coderobe coderobe self-assigned this May 24, 2023
@coderobe
Copy link
Contributor

coderobe commented May 25, 2023 •
edited
Loading

backported paritytech/substrate@0cf64f8 per @acatangiu request

@coderobe
Copy link
Contributor

weights in https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines/285946

@coderobe
Copy link
Contributor

weights pr (master) #7298
weights pr (release branch) #7297

@coderobe
Copy link
Contributor

diff polkadot

!!! THE SUBWASM REDUCED DIFFER IS EXPERIMENTAL, DOUBLE CHECK THE RESULTS !!!
[≠] pallet 0: System -> 2 change(s)
  - constants changes:
    [≠] BlockWeights: [ 3, 0, 200, 76, 204, 0, 11, 0, 32, 74, 169, 209, 1, 19, 255, 255, 255, 255, 255, 255, 255, 255, 226, 102, 43, 26, 0, 1, 11, 72, 246, 84, ... ]
        [Value([Changed(0, U8Change(3, 7)), Changed(1, U8Change(0, 56)), Changed(2, U8Change(200, 255)), Changed(3, U8Change(76, 253)), Changed(4, U8Change(204, 104)), Changed(5, U8Change(0, 2)), Changed(6, U8Change(11, 0)), Changed(7, U8Change(0, 11)), Changed(8, U8Change(32, 0)), Changed(9, U8Change(74, 32)), Changed(10, U8Change(169, 74)), Changed(11, U8Change(209, 169)), Changed(12, U8Change(1, 209)), Changed(13, U8Change(19, 1)), Changed(14, U8Change(255, 19)), Changed(22, U8Change(226, 255)), Changed(23, U8Change(102, 2)), Changed(24, U8Change(43, 80)), Changed(25, U8Change(26, 170)), Changed(26, U8Change(0, 25)), Changed(27, U8Change(1, 0)), Changed(28, U8Change(11, 1)), Changed(29, U8Change(72, 11)), Changed(30, U8Change(246, 0)), Changed(31, U8Change(84, 60)), Changed(32, U8Change(144, 117)), Changed(33, U8Change(88, 144)), Changed(34, U8Change(1, 88)), Changed(35, U8Change(19, 1)), Changed(36, U8Change(163, 19)), Changed(37, U8Change(112, 163)), Changed(38, U8Change(61, 112)), Changed(39, U8Change(10, 61)), Changed(40, U8Change(215, 10)), Changed(41, U8Change(163, 215)), Changed(42, U8Change(112, 163)), Changed(43, U8Change(189, 112)), Changed(44, U8Change(1, 189)), Changed(45, U8Change(11, 1)), Changed(46, U8Change(0, 11)), Changed(47, U8Change(152, 0)), Changed(48, U8Change(247, 152)), Changed(49, U8Change(62, 247)), Changed(50, U8Change(93, 62)), Changed(51, U8Change(1, 93)), Changed(52, U8Change(19, 1)), Changed(53, U8Change(255, 19)), Changed(60, U8Change(191, 255)), Changed(61, U8Change(1, 191)), Changed(62, U8Change(0, 1)), Changed(64, U8Change(226, 0)), Changed(65, U8Change(102, 2)), Changed(66, U8Change(43, 80)), Changed(67, U8Change(26, 170)), Changed(68, U8Change(0, 25)), Changed(69, U8Change(1, 0)), Changed(70, U8Change(11, 1)), Changed(71, U8Change(72, 11)), Changed(72, U8Change(126, 0)), Changed(73, U8Change(167, 196)), Changed(74, U8Change(250, 199)), Changed(75, U8Change(204, 250)), Changed(76, U8Change(1, 204)), Changed(77, U8Change(19, 1)), Changed(78, U8Change(163, 19)), Changed(79, U8Change(112, 163)), Changed(80, U8Change(61, 112)), Changed(81, U8Change(10, 61)), Changed(82, U8Change(215, 10)), Changed(83, U8Change(163, 215)), Changed(84, U8Change(112, 163)), Changed(85, U8Change(253, 112)), Changed(86, U8Change(1, 253)), Changed(87, U8Change(11, 1)), Changed(88, U8Change(0, 11)), Changed(89, U8Change(32, 0)), Changed(90, U8Change(74, 32)), Changed(91, U8Change(169, 74)), Changed(92, U8Change(209, 169)), Changed(93, U8Change(1, 209)), Changed(94, U8Change(19, 1)), Changed(95, U8Change(255, 19)), Changed(103, U8Change(1, 255)), Changed(104, U8Change(7, 1)), Changed(105, U8Change(0, 7)), Changed(106, U8Change(136, 0)), Changed(107, U8Change(82, 136)), Changed(108, U8Change(106, 82)), Changed(109, U8Change(116, 106)), Changed(110, U8Change(19, 116)), Changed(111, U8Change(0, 19)), Changed(118, U8Change(64, 0)), Changed(119, U8Change(226, 64)), Changed(120, U8Change(102, 2)), Changed(121, U8Change(43, 80)), Changed(122, U8Change(26, 170)), Changed(123, U8Change(0, 25)), Added(127, 0)])]
    [≠] Version: [ 32, 112, 111, 108, 107, 97, 100, 111, 116, 60, 112, 97, 114, 105, 116, 121, 45, 112, 111, 108, 107, 97, 100, 111, 116, 0, 0, 0, 0, 204, 36, 0, ... ]
        [Value([Changed(29, U8Change(204, 214))])]

[≠] pallet 7: Staking -> 2 change(s)
  - calls changes:
    [≠]  0: bond ( controller: AccountIdLookupOf<T>, value: BalanceOf<T>, payee: RewardDestination<T::AccountId>, )  )
        [Signature(SignatureChange { args: [Changed(0, [Name(StringChange("controller", "value")), Ty(StringChange("AccountIdLookupOf<T>", "BalanceOf<T>"))]), Changed(1, [Name(StringChange("value", "payee")), Ty(StringChange("BalanceOf<T>", "RewardDestination<T::AccountId>"))]), Removed(2, ArgDesc { name: "payee", ty: "RewardDestination<T::AccountId>" })] })]
    [≠]  8: set_controller ( controller: AccountIdLookupOf<T>, )  )
        [Signature(SignatureChange { args: [Removed(0, ArgDesc { name: "controller", ty: "AccountIdLookupOf<T>" })] })]

[≠] pallet 36: ElectionProviderMultiPhase -> 2 change(s)
  - constants changes:
    [≠] MinerMaxWeight: [11, 72, 46, 8, 196, 87, 1, 19, 163, 112, 61, 10, 215, 163, 112, 189]
        [Value([Changed(1, U8Change(72, 200)), Changed(2, U8Change(46, 60)), Changed(3, U8Change(8, 119)), Changed(4, U8Change(196, 39)), Changed(5, U8Change(87, 86))])]
    [≠] SignedMaxWeight: [11, 72, 46, 8, 196, 87, 1, 19, 163, 112, 61, 10, 215, 163, 112, 189]
        [Value([Changed(1, U8Change(72, 200)), Changed(2, U8Change(46, 60)), Changed(3, U8Change(8, 119)), Changed(4, U8Change(196, 39)), Changed(5, U8Change(87, 86))])]

[≠] pallet 51: Configuration -> 3 change(s)
  - calls changes:
    [-] "set_ump_service_total_weight"
    [-] "set_ump_max_individual_weight"

  - storages changes:
    [≠] Default  ActiveConfig: [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, ... ]
        [DefaultValue([Changed(125, U8Change(0, 1)), Changed(127, U8Change(1, 0)), Changed(129, U8Change(0, 1)), Changed(131, U8Change(1, 0)), Changed(133, U8Change(0, 1)), Changed(135, U8Change(1, 0)), Changed(143, U8Change(0, 6)), Changed(145, U8Change(6, 0)), Changed(147, U8Change(0, 100)), Changed(149, U8Change(100, 0)), Changed(151, U8Change(0, 1)), Changed(153, U8Change(1, 0)), Changed(172, U8Change(0, 2)), Changed(173, U8Change(7, 0)), Changed(175, U8Change(200, 0)), Changed(176, U8Change(23, 2)), Changed(177, U8Change(168, 0)), Changed(178, U8Change(4, 0)), Changed(179, U8Change(2, 0)), Removed(180, 0), Removed(181, 64), Removed(182, 1), Removed(183, 0), Removed(184, 2), Removed(185, 0), Removed(186, 0), Removed(187, 0), Removed(188, 2), Removed(189, 0), Removed(190, 0), Removed(191, 0)])]

[≠] pallet 53: ParaInclusion -> 1 change(s)
  - events changes:
    [+] EventDesc { index: 3, name: "UpwardMessagesReceived", signature: SignatureDesc { args: [ArgDesc { name: "from", ty: "ParaId" }, ArgDesc { name: "count", ty: "u32" }] } }

[≠] pallet 56: Paras -> 2 change(s)
  - errors changes:
    [≠] 11: PvfCheckDisabled
        [Name(StringChange("PvfCheckDisabled", "CannotUpgradeCode"))]
    [-] "CannotUpgradeCode"

[+] id: 63 - new pallet: ParasSlashing
[≠] pallet 70: Registrar -> 1 change(s)
  - events changes:
    [+] EventDesc { index: 3, name: "Swapped", signature: SignatureDesc { args: [ArgDesc { name: "para_id", ty: "ParaId" }, ArgDesc { name: "other_id", ty: "ParaId" }] } }

[+] id: 100 - new pallet: MessageQueue
[-] pallet 59: Ump
SUMMARY:
- Compatible.......................: false
- Require transaction_version bump.: false

@coderobe
Copy link
Contributor

diff kusama

!!! THE SUBWASM REDUCED DIFFER IS EXPERIMENTAL, DOUBLE CHECK THE RESULTS !!!
[≠] pallet 0: System -> 2 change(s)
  - constants changes:
    [≠] BlockWeights: [ 3, 96, 66, 167, 206, 0, 11, 0, 32, 74, 169, 209, 1, 19, 255, 255, 255, 255, 255, 255, 255, 255, 162, 20, 114, 26, 0, 1, 11, 216, 74, 67, ... ]
        [Value([Changed(0, U8Change(3, 7)), Changed(1, U8Change(96, 104)), Changed(2, U8Change(66, 95)), Changed(3, U8Change(167, 28)), Changed(4, U8Change(206, 111)), Changed(5, U8Change(0, 2)), Changed(6, U8Change(11, 0)), Changed(7, U8Change(0, 11)), Changed(8, U8Change(32, 0)), Changed(9, U8Change(74, 32)), Changed(10, U8Change(169, 74)), Changed(11, U8Change(209, 169)), Changed(12, U8Change(1, 209)), Changed(13, U8Change(19, 1)), Changed(14, U8Change(255, 19)), Changed(22, U8Change(162, 255)), Changed(23, U8Change(20, 2)), Changed(24, U8Change(114, 12)), Changed(25, U8Change(26, 223)), Changed(26, U8Change(0, 25)), Changed(27, U8Change(1, 0)), Changed(28, U8Change(11, 1)), Changed(29, U8Change(216, 11)), Changed(30, U8Change(74, 0)), Changed(31, U8Change(67, 13)), Changed(32, U8Change(144, 104)), Changed(33, U8Change(88, 144)), Changed(34, U8Change(1, 88)), Changed(35, U8Change(19, 1)), Changed(36, U8Change(163, 19)), Changed(37, U8Change(112, 163)), Changed(38, U8Change(61, 112)), Changed(39, U8Change(10, 61)), Changed(40, U8Change(215, 10)), Changed(41, U8Change(163, 215)), Changed(42, U8Change(112, 163)), Changed(43, U8Change(189, 112)), Changed(44, U8Change(1, 189)), Changed(45, U8Change(11, 1)), Changed(46, U8Change(0, 11)), Changed(47, U8Change(152, 0)), Changed(48, U8Change(247, 152)), Changed(49, U8Change(62, 247)), Changed(50, U8Change(93, 62)), Changed(51, U8Change(1, 93)), Changed(52, U8Change(19, 1)), Changed(53, U8Change(255, 19)), Changed(60, U8Change(191, 255)), Changed(61, U8Change(1, 191)), Changed(62, U8Change(0, 1)), Changed(64, U8Change(162, 0)), Changed(65, U8Change(20, 2)), Changed(66, U8Change(114, 12)), Changed(67, U8Change(26, 223)), Changed(68, U8Change(0, 25)), Changed(69, U8Change(1, 0)), Changed(70, U8Change(11, 1)), Changed(71, U8Change(216, 11)), Changed(72, U8Change(210, 0)), Changed(74, U8Change(250, 186)), Changed(75, U8Change(204, 250)), Changed(76, U8Change(1, 204)), Changed(77, U8Change(19, 1)), Changed(78, U8Change(163, 19)), Changed(79, U8Change(112, 163)), Changed(80, U8Change(61, 112)), Changed(81, U8Change(10, 61)), Changed(82, U8Change(215, 10)), Changed(83, U8Change(163, 215)), Changed(84, U8Change(112, 163)), Changed(85, U8Change(253, 112)), Changed(86, U8Change(1, 253)), Changed(87, U8Change(11, 1)), Changed(88, U8Change(0, 11)), Changed(89, U8Change(32, 0)), Changed(90, U8Change(74, 32)), Changed(91, U8Change(169, 74)), Changed(92, U8Change(209, 169)), Changed(93, U8Change(1, 209)), Changed(94, U8Change(19, 1)), Changed(95, U8Change(255, 19)), Changed(103, U8Change(1, 255)), Changed(104, U8Change(7, 1)), Changed(105, U8Change(0, 7)), Changed(106, U8Change(136, 0)), Changed(107, U8Change(82, 136)), Changed(108, U8Change(106, 82)), Changed(109, U8Change(116, 106)), Changed(110, U8Change(19, 116)), Changed(111, U8Change(0, 19)), Changed(118, U8Change(64, 0)), Changed(119, U8Change(162, 64)), Changed(120, U8Change(20, 2)), Changed(121, U8Change(114, 12)), Changed(122, U8Change(26, 223)), Changed(123, U8Change(0, 25)), Added(127, 0)])]
    [≠] Version: [ 24, 107, 117, 115, 97, 109, 97, 52, 112, 97, 114, 105, 116, 121, 45, 107, 117, 115, 97, 109, 97, 2, 0, 0, 0, 204, 36, 0, 0, 0, 0, 0, ... ]
        [Value([Changed(25, U8Change(204, 214))])]

[≠] pallet 6: Staking -> 2 change(s)
  - calls changes:
    [≠]  0: bond ( controller: AccountIdLookupOf<T>, value: BalanceOf<T>, payee: RewardDestination<T::AccountId>, )  )
        [Signature(SignatureChange { args: [Changed(0, [Name(StringChange("controller", "value")), Ty(StringChange("AccountIdLookupOf<T>", "BalanceOf<T>"))]), Changed(1, [Name(StringChange("value", "payee")), Ty(StringChange("BalanceOf<T>", "RewardDestination<T::AccountId>"))]), Removed(2, ArgDesc { name: "payee", ty: "RewardDestination<T::AccountId>" })] })]
    [≠]  8: set_controller ( controller: AccountIdLookupOf<T>, )  )
        [Signature(SignatureChange { args: [Removed(0, ArgDesc { name: "controller", ty: "AccountIdLookupOf<T>" })] })]

[≠] pallet 37: ElectionProviderMultiPhase -> 2 change(s)
  - constants changes:
    [≠] MinerMaxWeight: [11, 120, 8, 156, 193, 87, 1, 19, 163, 112, 61, 10, 215, 163, 112, 189]
        [Value([Changed(1, U8Change(120, 152)), Changed(2, U8Change(8, 173)), Changed(3, U8Change(156, 75)), Changed(4, U8Change(193, 33)), Changed(5, U8Change(87, 86))])]
    [≠] SignedMaxWeight: [11, 120, 8, 156, 193, 87, 1, 19, 163, 112, 61, 10, 215, 163, 112, 189]
        [Value([Changed(1, U8Change(120, 152)), Changed(2, U8Change(8, 173)), Changed(3, U8Change(156, 75)), Changed(4, U8Change(193, 33)), Changed(5, U8Change(87, 86))])]

[≠] pallet 51: Configuration -> 3 change(s)
  - calls changes:
    [-] "set_ump_service_total_weight"
    [-] "set_ump_max_individual_weight"

  - storages changes:
    [≠] Default  ActiveConfig: [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, ... ]
        [DefaultValue([Changed(125, U8Change(0, 1)), Changed(127, U8Change(1, 0)), Changed(129, U8Change(0, 1)), Changed(131, U8Change(1, 0)), Changed(133, U8Change(0, 1)), Changed(135, U8Change(1, 0)), Changed(143, U8Change(0, 6)), Changed(145, U8Change(6, 0)), Changed(147, U8Change(0, 100)), Changed(149, U8Change(100, 0)), Changed(151, U8Change(0, 1)), Changed(153, U8Change(1, 0)), Changed(172, U8Change(0, 2)), Changed(173, U8Change(7, 0)), Changed(175, U8Change(200, 0)), Changed(176, U8Change(23, 2)), Changed(177, U8Change(168, 0)), Changed(178, U8Change(4, 0)), Changed(179, U8Change(2, 0)), Removed(180, 0), Removed(181, 64), Removed(182, 1), Removed(183, 0), Removed(184, 2), Removed(185, 0), Removed(186, 0), Removed(187, 0), Removed(188, 2), Removed(189, 0), Removed(190, 0), Removed(191, 0)])]

[≠] pallet 53: ParaInclusion -> 1 change(s)
  - events changes:
    [+] EventDesc { index: 3, name: "UpwardMessagesReceived", signature: SignatureDesc { args: [ArgDesc { name: "from", ty: "ParaId" }, ArgDesc { name: "count", ty: "u32" }] } }

[≠] pallet 56: Paras -> 2 change(s)
  - errors changes:
    [≠] 11: PvfCheckDisabled
        [Name(StringChange("PvfCheckDisabled", "CannotUpgradeCode"))]
    [-] "CannotUpgradeCode"

[≠] pallet 70: Registrar -> 1 change(s)
  - events changes:
    [+] EventDesc { index: 3, name: "Swapped", signature: SignatureDesc { args: [ArgDesc { name: "para_id", ty: "ParaId" }, ArgDesc { name: "other_id", ty: "ParaId" }] } }

[+] id: 100 - new pallet: MessageQueue
[-] pallet 59: Ump
SUMMARY:
- Compatible.......................: false
- Require transaction_version bump.: false

@coderobe
Copy link
Contributor

diff westend

!!! THE SUBWASM REDUCED DIFFER IS EXPERIMENTAL, DOUBLE CHECK THE RESULTS !!!
[≠] pallet 0: System -> 2 change(s)
  - constants changes:
    [≠] BlockWeights: [ 98, 168, 191, 95, 0, 11, 0, 32, 74, 169, 209, 1, 19, 255, 255, 255, 255, 255, 255, 255, 255, 2, 236, 31, 23, 0, 1, 11, 0, 213, 23, 145, ... ]
        [Value([Changed(0, U8Change(98, 2)), Changed(1, U8Change(168, 61)), Changed(2, U8Change(191, 36)), Changed(3, U8Change(95, 93)), Changed(21, U8Change(2, 34)), Changed(22, U8Change(236, 83)), Changed(23, U8Change(31, 7)), Changed(28, U8Change(0, 56)), Changed(29, U8Change(213, 251)), Changed(30, U8Change(23, 29)), Changed(63, U8Change(2, 34)), Changed(64, U8Change(236, 83)), Changed(65, U8Change(31, 7)), Changed(70, U8Change(0, 56)), Changed(71, U8Change(93, 131)), Changed(72, U8Change(106, 112)), Changed(118, U8Change(2, 34)), Changed(119, U8Change(236, 83)), Changed(120, U8Change(31, 7))])]
    [≠] Version: [ 28, 119, 101, 115, 116, 101, 110, 100, 56, 112, 97, 114, 105, 116, 121, 45, 119, 101, 115, 116, 101, 110, 100, 2, 0, 0, 0, 204, 36, 0, 0, 0, ... ]
        [Value([Changed(27, U8Change(204, 214))])]

[≠] pallet 6: Staking -> 2 change(s)
  - calls changes:
    [≠]  0: bond ( controller: AccountIdLookupOf<T>, value: BalanceOf<T>, payee: RewardDestination<T::AccountId>, )  )
        [Signature(SignatureChange { args: [Changed(0, [Name(StringChange("controller", "value")), Ty(StringChange("AccountIdLookupOf<T>", "BalanceOf<T>"))]), Changed(1, [Name(StringChange("value", "payee")), Ty(StringChange("BalanceOf<T>", "RewardDestination<T::AccountId>"))]), Removed(2, ArgDesc { name: "payee", ty: "RewardDestination<T::AccountId>" })] })]
    [≠]  8: set_controller ( controller: AccountIdLookupOf<T>, )  )
        [Signature(SignatureChange { args: [Removed(0, ArgDesc { name: "controller", ty: "AccountIdLookupOf<T>" })] })]

[≠] pallet 24: ElectionProviderMultiPhase -> 2 change(s)
  - constants changes:
    [≠] MinerMaxWeight: [11, 232, 234, 39, 121, 88, 1, 19, 163, 112, 61, 10, 215, 163, 112, 189]
        [Value([Changed(1, U8Change(232, 248)), Changed(2, U8Change(234, 235)), Changed(3, U8Change(39, 212))])]
    [≠] SignedMaxWeight: [11, 232, 234, 39, 121, 88, 1, 19, 163, 112, 61, 10, 215, 163, 112, 189]
        [Value([Changed(1, U8Change(232, 248)), Changed(2, U8Change(234, 235)), Changed(3, U8Change(39, 212))])]

[≠] pallet 42: Configuration -> 3 change(s)
  - calls changes:
    [-] "set_ump_service_total_weight"
    [-] "set_ump_max_individual_weight"

  - storages changes:
    [≠] Default  ActiveConfig: [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, ... ]
        [DefaultValue([Changed(125, U8Change(0, 1)), Changed(127, U8Change(1, 0)), Changed(129, U8Change(0, 1)), Changed(131, U8Change(1, 0)), Changed(133, U8Change(0, 1)), Changed(135, U8Change(1, 0)), Changed(143, U8Change(0, 6)), Changed(145, U8Change(6, 0)), Changed(147, U8Change(0, 100)), Changed(149, U8Change(100, 0)), Changed(151, U8Change(0, 1)), Changed(153, U8Change(1, 0)), Changed(172, U8Change(0, 2)), Changed(173, U8Change(7, 0)), Changed(175, U8Change(200, 0)), Changed(176, U8Change(23, 2)), Changed(177, U8Change(168, 0)), Changed(178, U8Change(4, 0)), Changed(179, U8Change(2, 0)), Removed(180, 0), Removed(181, 64), Removed(182, 1), Removed(183, 0), Removed(184, 2), Removed(185, 0), Removed(186, 0), Removed(187, 0), Removed(188, 2), Removed(189, 0), Removed(190, 0), Removed(191, 0)])]

[≠] pallet 44: ParaInclusion -> 1 change(s)
  - events changes:
    [+] EventDesc { index: 3, name: "UpwardMessagesReceived", signature: SignatureDesc { args: [ArgDesc { name: "from", ty: "ParaId" }, ArgDesc { name: "count", ty: "u32" }] } }

[≠] pallet 47: Paras -> 2 change(s)
  - errors changes:
    [≠] 11: PvfCheckDisabled
        [Name(StringChange("PvfCheckDisabled", "CannotUpgradeCode"))]
    [-] "CannotUpgradeCode"

[≠] pallet 60: Registrar -> 1 change(s)
  - events changes:
    [+] EventDesc { index: 3, name: "Swapped", signature: SignatureDesc { args: [ArgDesc { name: "para_id", ty: "ParaId" }, ArgDesc { name: "other_id", ty: "ParaId" }] } }

[+] id: 100 - new pallet: MessageQueue
[-] pallet 50: Ump
SUMMARY:
- Compatible.......................: false
- Require transaction_version bump.: false

@coderobe
Copy link
Contributor

diff rococo

!!! THE SUBWASM REDUCED DIFFER IS EXPERIMENTAL, DOUBLE CHECK THE RESULTS !!!
[≠] pallet 0: System -> 2 change(s)
  - constants changes:
    [≠] BlockWeights: [ 130, 90, 74, 98, 0, 11, 0, 32, 74, 169, 209, 1, 19, 255, 255, 255, 255, 255, 255, 255, 255, 66, 33, 70, 23, 0, 1, 11, 176, 71, 14, 145, ... ]
        [Value([Changed(1, U8Change(90, 206)), Changed(2, U8Change(74, 132)), Changed(3, U8Change(98, 99)), Changed(21, U8Change(66, 130)), Changed(22, U8Change(33, 217)), Changed(23, U8Change(70, 107)), Changed(28, U8Change(176, 160)), Changed(29, U8Change(71, 217)), Changed(30, U8Change(14, 4)), Changed(63, U8Change(66, 130)), Changed(64, U8Change(33, 217)), Changed(65, U8Change(70, 107)), Changed(70, U8Change(176, 160)), Changed(71, U8Change(207, 97)), Changed(72, U8Change(96, 87)), Changed(118, U8Change(66, 130)), Changed(119, U8Change(33, 217)), Changed(120, U8Change(70, 107))])]
    [≠] Version: [ 24, 114, 111, 99, 111, 99, 111, 72, 112, 97, 114, 105, 116, 121, 45, 114, 111, 99, 111, 99, 111, 45, 118, 50, 46, 48, 0, 0, 0, 0, 204, 36, ... ]
        [Value([Changed(30, U8Change(204, 214))])]

[≠] pallet 51: Configuration -> 3 change(s)
  - calls changes:
    [-] "set_ump_service_total_weight"
    [-] "set_ump_max_individual_weight"

  - storages changes:
    [≠] Default  ActiveConfig: [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, ... ]
        [DefaultValue([Changed(125, U8Change(0, 1)), Changed(127, U8Change(1, 0)), Changed(129, U8Change(0, 1)), Changed(131, U8Change(1, 0)), Changed(133, U8Change(0, 1)), Changed(135, U8Change(1, 0)), Changed(143, U8Change(0, 6)), Changed(145, U8Change(6, 0)), Changed(147, U8Change(0, 100)), Changed(149, U8Change(100, 0)), Changed(151, U8Change(0, 1)), Changed(153, U8Change(1, 0)), Changed(172, U8Change(0, 2)), Changed(173, U8Change(7, 0)), Changed(175, U8Change(200, 0)), Changed(176, U8Change(23, 2)), Changed(177, U8Change(168, 0)), Changed(178, U8Change(4, 0)), Changed(179, U8Change(2, 0)), Removed(180, 0), Removed(181, 64), Removed(182, 1), Removed(183, 0), Removed(184, 2), Removed(185, 0), Removed(186, 0), Removed(187, 0), Removed(188, 2), Removed(189, 0), Removed(190, 0), Removed(191, 0)])]

[≠] pallet 53: ParaInclusion -> 1 change(s)
  - events changes:
    [+] EventDesc { index: 3, name: "UpwardMessagesReceived", signature: SignatureDesc { args: [ArgDesc { name: "from", ty: "ParaId" }, ArgDesc { name: "count", ty: "u32" }] } }

[≠] pallet 56: Paras -> 2 change(s)
  - errors changes:
    [≠] 11: PvfCheckDisabled
        [Name(StringChange("PvfCheckDisabled", "CannotUpgradeCode"))]
    [-] "CannotUpgradeCode"

[+] id: 64 - new pallet: MessageQueue
[≠] pallet 70: Registrar -> 1 change(s)
  - events changes:
    [+] EventDesc { index: 3, name: "Swapped", signature: SignatureDesc { args: [ArgDesc { name: "para_id", ty: "ParaId" }, ArgDesc { name: "other_id", ty: "ParaId" }] } }

[-] pallet 59: Ump
SUMMARY:
- Compatible.......................: false
- Require transaction_version bump.: false

@bkchr
Copy link
Member

bkchr commented Jun 1, 2023

Given that the bond and set_controller have changed the signature, I would propose a transaction_version bump. The runtime should not decode calls made for the old version, but let's play it safe.

@coderobe
Copy link
Contributor

coderobe commented Jun 1, 2023

transaction_version bumped in 88178b9

@coderobe
Copy link
Contributor

coderobe commented Jun 7, 2023

westend deployment https://github.com/paritytech/devops/issues/2620

@coderobe
Copy link
Contributor

coderobe commented Jun 7, 2023 •
edited
Loading

westend fell over, probably have to backport #7340 or similar

edit: backported

@coderobe
Copy link
Contributor

westend is back up, waiting on deployment

@coderobe
Copy link
Contributor

westend deployed

@coderobe
Copy link
Contributor

released

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@coderobe coderobe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkchr @coderobe