Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

PVF worker: restrict access to env vars #7326

Closed
mrcnski opened this issue Jun 2, 2023 · 0 comments · Fixed by #7330
Closed

PVF worker: restrict access to env vars #7326

mrcnski opened this issue Jun 2, 2023 · 0 comments · Fixed by #7330
Assignees
@mrcnski
Labels
T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance.

Comments

@mrcnski
Copy link
Contributor

mrcnski commented Jun 2, 2023

ISSUE

Overview

Here's another idea I got from looking at birdcage. Why not remove all the env vars at the start of the PVF worker process? There could be sensitive stuff in there. I don't think any are required for PVF jobs to function, and this should be easy to do.

See also paritytech/polkadot-sdk#619.
@mrcnski mrcnski added the T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance. label Jun 2, 2023
@mrcnski mrcnski mentioned this issue Jun 4, 2023
Merged
1 task
@mrcnski mrcnski self-assigned this Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrcnski mrcnski

Labels
T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance.
Projects
No open projects
PVF Security Hardening
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PVF worker: Prevent access to env vars paritytech/polkadot
1 participant
@mrcnski