Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Req: filenames minimal #12

Closed
nuke-web3 opened this issue Oct 9, 2023 · 2 comments
Closed

Feat Req: filenames minimal #12

nuke-web3 opened this issue Oct 9, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@nuke-web3
Copy link

nuke-web3 commented Oct 9, 2023

Tiny nit, while still early: IMHO the pr_###.prdoc is kinda redundant. We should rather just use the PR number as the file name, and perhaps a README.md in the repo this is used in located in ./prdoc/... that describes the TLDR of what these files are and points to this repo.

@nuke-web3 nuke-web3 added the enhancement New feature or request label Oct 9, 2023
@chevdor
Copy link
Contributor

chevdor commented Oct 18, 2023

Yes, I cannot really disagree but that will be transparent to the user using prdoc to generate a new prdoc since the name is generate for you.

With the new version I am working on in #13, users won't need to provide the prdoc folder at alll, this will be part of the config and defined per repo.

@mutantcornholio
Copy link
Contributor

Outdated: we aren't providing file name anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants