Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check reviews in a merge queue #100

Closed
alvicsam opened this issue Nov 16, 2023 · 1 comment
Closed

Don't check reviews in a merge queue #100

alvicsam opened this issue Nov 16, 2023 · 1 comment
Assignees
@Bullrich

Comments

@alvicsam
Copy link
Contributor

Currently neither prcr, not review-bot don't support merge queues. We would like to turn them on in the polkadot-sdk repo (related issue can be found here).

Review bot should return green status when it's running in a merge queue. Since this check is going to be required I can't add simple skip check in a github action (like here).
@Bullrich Bullrich self-assigned this Nov 17, 2023
@Bullrich Bullrich mentioned this issue Nov 20, 2023
Merged
@alvicsam
Copy link
Contributor Author

Done with workaround, thanks @Bullrich !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bullrich Bullrich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bullrich @alvicsam