Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GET /accounts/{accountID}/foreign-asset-balances endpoint #1449

Open
IkerAlus opened this issue Jun 10, 2024 · 1 comment
Open

Add GET /accounts/{accountID}/foreign-asset-balances endpoint #1449

IkerAlus opened this issue Jun 10, 2024 · 1 comment
Labels
C1 - Parachain Related to a Parachain I8 - Enhancement Additional feature request P7 - Nice to Have Nice, but not urgent

Comments

@IkerAlus
Copy link
Contributor

The possibility of querying the balances of the foreign assets of a given account in Asset Hub should be enabled. Unlike for the existing GET /accounts/{accountID}/asset-balances case, in this case the optional input assets is an array of XCM locations. We assume the user knows how to provide this asset ID properly (in the same format it is provided in PJS API, Polkadot-API or Asset Transfer API), and no special validation for this input should be implemented. If there is no storage entry for the asset ID provided, we should just return error stating that the asset is not found.

Note: This is the feature completing the previous issue: #1287

@IkerAlus IkerAlus added I8 - Enhancement Additional feature request P7 - Nice to Have Nice, but not urgent C1 - Parachain Related to a Parachain labels Jun 10, 2024
@IkerAlus
Copy link
Contributor Author

Instead of adding and endpoint per pallet instance, the right approach would be to support the APIs exposed as per paritytech/cumulus#2180 (comment) and/or the longer term more stable approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C1 - Parachain Related to a Parachain I8 - Enhancement Additional feature request P7 - Nice to Have Nice, but not urgent
Projects
None yet
Development

No branches or pull requests

1 participant