Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Odd bug when updating to master #10667

Closed
drewstone opened this issue Jan 14, 2022 · 3 comments
Closed

Odd bug when updating to master #10667

drewstone opened this issue Jan 14, 2022 · 3 comments

Comments

@drewstone
Copy link
Contributor

Getting build errors that default isn't implemented for AccountId causing a myriad of other errors. Any idea why this occurs when updating to the master branch?

161 |     #[pallet::storage]
    |               ^^^^^^^ the trait `std::default::Default` is not implemented for `<T as frame_system::Config>::AccountId`
@apopiak
Copy link
Contributor

apopiak commented Jan 14, 2022

This PR is the reason: #10403
TLDR: AccountId should not have a default value, so it was removed.

@drewstone
Copy link
Contributor Author

drewstone commented Jan 14, 2022

So the recommendation is convert all instantiations to Option<T::AccountId> in the pallet's storage? @apopiak

@nazar-pc
Copy link
Contributor

Many things were updated in that PR, just follow those examples. In some cases Option<T::AccountId> might make sense, in other cases something different, all depends on the use case.

@apopiak apopiak closed this as completed Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants